From owner-freebsd-fs@FreeBSD.ORG  Tue Nov  4 03:32:28 2008
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 934011065674
	for <freebsd-fs@freebsd.org>; Tue,  4 Nov 2008 03:32:28 +0000 (UTC)
	(envelope-from borisxm@gmail.com)
Received: from yx-out-2324.google.com (yx-out-2324.google.com [74.125.44.30])
	by mx1.freebsd.org (Postfix) with ESMTP id 44E1C8FC1F
	for <freebsd-fs@freebsd.org>; Tue,  4 Nov 2008 03:32:28 +0000 (UTC)
	(envelope-from borisxm@gmail.com)
Received: by yx-out-2324.google.com with SMTP id 8so1057062yxb.13
	for <freebsd-fs@freebsd.org>; Mon, 03 Nov 2008 19:32:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:received:message-id:date:from:sender
	:to:subject:cc:in-reply-to:mime-version:content-type
	:content-transfer-encoding:content-disposition:references
	:x-google-sender-auth;
	bh=fKra00DrGuGzXY3VOJNNImMG53K5a1WPEsJTXpA4Ozc=;
	b=saDGIhcLEDJFnHgO3vhRZ0IvGRKwDcTkIpVx0QCM9pXku/SPH7cHTMOej0Mtq4y3un
	vWi01ST5s0BXXR8KFTI589/hjQrP91W0ZU9zcM0IGTeJBLQcKHQsD4OZtT03N3oTNkHE
	gwiEefFJlH+YnMxDGVDo6IGuifnoOsskXnHM8=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version
	:content-type:content-transfer-encoding:content-disposition
	:references:x-google-sender-auth;
	b=S1hu1b6akl19wT4rr52ex5yJgfON1OVy4HPW/M3NafVRBgrDRh77mN4/7dsU9YFE3G
	BiqgLVOuUPx7uRAyjrBLtMJAI29twuC2sl+5LLLoIysZuXq79X4V/O8bJN+2LX9idE99
	0Vz+VZa3GhgR7HbG0dgC84webJFEpCpsdT8Es=
Received: by 10.64.195.20 with SMTP id s20mr1163094qbf.20.1225768031925;
	Mon, 03 Nov 2008 19:07:11 -0800 (PST)
Received: by 10.64.84.17 with HTTP; Mon, 3 Nov 2008 19:07:11 -0800 (PST)
Message-ID: <35ab6dd50811031907t2ecd2ddeq82187464a1bbf3c0@mail.gmail.com>
Date: Tue, 4 Nov 2008 09:07:11 +0600
From: "Boris Popov" <bp@freebsd.org>
Sender: borisxm@gmail.com
To: "Attilio Rao" <attilio@freebsd.org>
In-Reply-To: <3bbf2fe10811020817g1409a38ep26c1ee8edf075201@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20081102123100.GA1434@darklight.homeunix.org>
	<3bbf2fe10811020737g211dfb3fs54b48e4071db2393@mail.gmail.com>
	<3bbf2fe10811020817g1409a38ep26c1ee8edf075201@mail.gmail.com>
X-Google-Sender-Auth: 08a9158a34bfd8c5
Cc: Yuri Pankov <yuri.pankov@gmail.com>, freebsd-fs@freebsd.org,
	freebsd-current@freebsd.org
Subject: Re: reproducible panic with mount_smbfs
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Nov 2008 03:32:28 -0000

On Sun, Nov 2, 2008 at 10:17 PM, Attilio Rao <attilio@freebsd.org> wrote:
> Yuri,
> could you please test this fix:
> http://www.freebsd.org/~attilio/netsmb.diff

  This patch looks wrong to me. AFAIR, the test (LK_EXCLUSIVE &&
(flags & LK_CANRECURSE)) were intended
to prevent situations when SMB connection can not handle multiple
requests (eg, during connection setup).
But I do agree, that error processing of the lock status is bogus.

-- 
Boris Popov