From owner-freebsd-hackers@FreeBSD.ORG Sun Oct 7 14:11:23 2012 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 75786106564A; Sun, 7 Oct 2012 14:11:23 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id CBE7D8FC0A; Sun, 7 Oct 2012 14:11:22 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q97EBUU8023980; Sun, 7 Oct 2012 17:11:30 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q97EBIuV004831; Sun, 7 Oct 2012 17:11:18 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q97EBIRA004830; Sun, 7 Oct 2012 17:11:18 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 7 Oct 2012 17:11:18 +0300 From: Konstantin Belousov To: Andriy Gapon Message-ID: <20121007141118.GW35915@deviant.kiev.zoral.com.ua> References: <507172DA.2020309@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CLy2MrvMHpW9mjhY" Content-Disposition: inline In-Reply-To: <507172DA.2020309@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: freebsd-hackers Subject: Re: machine/cpu.h in userland X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Oct 2012 14:11:23 -0000 --CLy2MrvMHpW9mjhY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 07, 2012 at 03:17:30PM +0300, Andriy Gapon wrote: >=20 > I noticed that couple of our userland file include machine/cpu.h for no a= pparent > good reason. It looks like at least amd64 cpu.h has no userland servicea= ble > parts inside. > Maybe its content should be put under _KERNEL ? >=20 > Also: >=20 > --- a/sbin/adjkerntz/adjkerntz.c > +++ b/sbin/adjkerntz/adjkerntz.c > @@ -51,7 +51,6 @@ __FBSDID("$FreeBSD$"); > #include > #include > #include > -#include > #include >=20 > #include "pathnames.h" > diff --git a/usr.bin/w/w.c b/usr.bin/w/w.c > index 8441ce5..9674fc2 100644 > --- a/usr.bin/w/w.c > +++ b/usr.bin/w/w.c > @@ -57,7 +57,6 @@ static const char sccsid[] =3D "@(#)w.c 8.4 (Berkeley) = 4/16/94"; > #include > #include >=20 > -#include > #include > #include > #include Both proposals are obviously fine. Some research with git blame traces the include presence in the w.c to the 4.4 Lite import. What I do not understand is why do you spam lists instead of commmitting the obvious changes ? --CLy2MrvMHpW9mjhY Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAlBxjYYACgkQC3+MBN1Mb4gbZACgjj5XP4xZJPDVQkz/9t13TBA8 QDsAnR8v1n5IgnKkqOkgzq802v6pwA8m =e9Kw -----END PGP SIGNATURE----- --CLy2MrvMHpW9mjhY--