From owner-freebsd-current@freebsd.org Fri Nov 6 23:35:42 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E85382D695E for ; Fri, 6 Nov 2020 23:35:42 +0000 (UTC) (envelope-from mike@sentex.net) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4CScFp3v6cz3Cy9 for ; Fri, 6 Nov 2020 23:35:42 +0000 (UTC) (envelope-from mike@sentex.net) Received: by mailman.nyi.freebsd.org (Postfix) id 85A882D695D; Fri, 6 Nov 2020 23:35:42 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 857162D695C for ; Fri, 6 Nov 2020 23:35:42 +0000 (UTC) (envelope-from mike@sentex.net) Received: from pyroxene2a.sentex.ca (pyroxene19.sentex.ca [IPv6:2607:f3e0:0:3::19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "pyroxene.sentex.ca", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CScFp3CQRz3Cy8; Fri, 6 Nov 2020 23:35:42 +0000 (UTC) (envelope-from mike@sentex.net) Received: from [IPv6:2607:f3e0:0:4:adfd:30ed:295d:5262] ([IPv6:2607:f3e0:0:4:adfd:30ed:295d:5262]) by pyroxene2a.sentex.ca (8.15.2/8.15.2) with ESMTPS id 0A6NZfJb018688 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO); Fri, 6 Nov 2020 18:35:41 -0500 (EST) (envelope-from mike@sentex.net) Subject: Re: Link flap when adding / removing a vlan (was Re: r360902 breaks VLAN interface on if_em (82579LM)) To: Eric Joyner Cc: lev@freebsd.org, current References: <88004d48-4434-875a-5a36-0627b00c2f38@gmail.com> <1906251966.36777.1590562439792.JavaMail.open-xchange@opme11oxm03aub.bagnolet.francetelecom.fr> <997c1389-5e18-b07e-d342-c787c841a4c4@gmail.com> <711876429.20200601003941@serebryakov.spb.ru> From: mike tancsa Message-ID: <05a17072-570a-6e05-d3e6-802b3bf30e57@sentex.net> Date: Fri, 6 Nov 2020 18:35:43 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 4CScFp3CQRz3Cy8 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Nov 2020 23:35:43 -0000 On 11/6/2020 5:32 PM, Eric Joyner wrote: > Could you reply to that issue with what you've found? > > Though, as far as I can recall, igb(4) devices are not supposed to do > the iflib reset talked about in the bug, so I wouldn't expect to see a > link flap on those. > Hi Eric,     I have added my findings to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240818 I tried it on 3 different vendor's boards. All I210 variants it seems. I am testing with --- if_em.c     2020-11-06 15:00:22.120953000 -0500 +++ /tmp/if_em.c        2020-11-06 14:59:55.678195000 -0500 @@ -4047,6 +4047,7 @@  {         switch (event) {         case IFLIB_RESTART_VLAN_CONFIG: +               return (false);         default:                 return (true);         } And if fixes the problem, but not quite sure if it introduces any regressions or other issues ?     ---Mike > - Eric > > On Fri, Nov 6, 2020 at 12:48 PM mike tancsa > wrote: > > On 11/6/2020 2:17 PM, mike tancsa wrote: > > On 5/31/2020 5:39 PM, Lev Serebryakov wrote: > >> Hello Ian, > >> > >> Thursday, May 28, 2020, 2:45:48 AM, you wrote: > >> > >>> I noticed that my VLAN interfaces stopped working after a > recent build.  > >>> tcpdump showed traffic leaving leaving and entering the > interface but no > >>> host on the network actually received any packets from this > host.  A > >>> binary search led me to r360902 and indeed the following > change fixed > >>> the issue for me: > >>  Problem is, this change will return terrible situation when > adding new VLAN > >> will flap connection status. > >> > >>  It all worked before iflib: hardware VLAN filtering worked, and > >> adding/removing new VLAN didn't cause link to flap. > >> > >>  Now, with iflib, looks like we can not have all good things at > once :( > > > Looks like this is captured in > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240818 > > > > > Hi All, > > > > Just came across this thread as I am running into this behaviour on > > RELENG_12.  Adding a new vlan causes all vlans on the parent > interface > > to flap. Not the greatest thing as it bounces a LOT of traffic > > potentially, flaps routing etc.  Is there a way around this ? > > > > This is on r367411 releng12 > > > > igb0@pci0:2:0:0:        class=0x020000 card=0x153315d9 > chip=0x15338086 > > rev=0x03 hdr=0x00 > >     vendor     = 'Intel Corporation' > >     device     = 'I210 Gigabit Network Connection' > >     class      = network > >     subclass   = ethernet > > > > eg. just something simple like > > > > ifconfig vlan16 create 10.1.2.3/29 vlandev > igb1 vlan 16 > > > >  # dmesg | tail -8 > > igb1: link state changed to DOWN > > vlan16: link state changed to DOWN > > vlan2049: link state changed to DOWN > > vlan15: link state changed to DOWN > > igb1: link state changed to UP > > vlan16: link state changed to UP > > vlan2049: link state changed to UP > > vlan15: link state changed to UP > > > > > >     ---Mike > > > > > > > > > > _______________________________________________ > > freebsd-current@freebsd.org > mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-current > > > To unsubscribe, send any mail to > "freebsd-current-unsubscribe@freebsd.org > " > > > _______________________________________________ > freebsd-current@freebsd.org > mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > > To unsubscribe, send any mail to > "freebsd-current-unsubscribe@freebsd.org > " >