Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 5 Dec 2012 13:56:56 +0000 (UTC)
From:      Eitan Adler <eadler@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r243898 - head/usr.sbin/pw
Message-ID:  <201212051356.qB5Duu0c068432@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: eadler
Date: Wed Dec  5 13:56:56 2012
New Revision: 243898
URL: http://svnweb.freebsd.org/changeset/base/243898

Log:
  Simplify string duplication: use strdup instead of malloc + strcpy
  
  Submitted by:	db
  Approved by:	cperciva
  MFC after:	2 weeks

Modified:
  head/usr.sbin/pw/grupd.c

Modified: head/usr.sbin/pw/grupd.c
==============================================================================
--- head/usr.sbin/pw/grupd.c	Wed Dec  5 13:56:52 2012	(r243897)
+++ head/usr.sbin/pw/grupd.c	Wed Dec  5 13:56:56 2012	(r243898)
@@ -50,12 +50,11 @@ setgrdir(const char * dir)
 {
 	if (dir == NULL)
 		return -1;
-	else {
-		char * d = malloc(strlen(dir)+1);
-		if (d == NULL)
-			return -1;
-		grpath = strcpy(d, dir);
-	}
+	else
+		grpath = strdup(dir);
+	if (grpath == NULL)
+		return -1;
+
 	return 0;
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201212051356.qB5Duu0c068432>