From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Oct 21 14:30:21 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BCE5416A4CE for ; Thu, 21 Oct 2004 14:30:21 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id A76F943D48 for ; Thu, 21 Oct 2004 14:30:21 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i9LEULTp057095 for ; Thu, 21 Oct 2004 14:30:21 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i9LEULEK057083; Thu, 21 Oct 2004 14:30:21 GMT (envelope-from gnats) Resent-Date: Thu, 21 Oct 2004 14:30:21 GMT Resent-Message-Id: <200410211430.i9LEULEK057083@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dmitry Morozovsky Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4328616A4CE for ; Thu, 21 Oct 2004 14:21:36 +0000 (GMT) Received: from woozle.rinet.ru (woozle.rinet.ru [195.54.192.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 82BBE43D31 for ; Thu, 21 Oct 2004 14:21:35 +0000 (GMT) (envelope-from marck@woozle.rinet.ru) Received: from woozle.rinet.ru (localhost [127.0.0.1]) by woozle.rinet.ru (8.13.1/8.13.1) with ESMTP id i9LELYFp023202 for ; Thu, 21 Oct 2004 18:21:34 +0400 (MSD) (envelope-from marck@woozle.rinet.ru) Received: (from marck@localhost) by woozle.rinet.ru (8.13.1/8.13.1/Submit) id i9LELY4U023201; Thu, 21 Oct 2004 18:21:34 +0400 (MSD) (envelope-from marck) Message-Id: <200410211421.i9LELY4U023201@woozle.rinet.ru> Date: Thu, 21 Oct 2004 18:21:34 +0400 (MSD) From: Dmitry Morozovsky To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/72963: www/oops fix memory leak X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Dmitry Morozovsky List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 14:30:21 -0000 >Number: 72963 >Category: ports >Synopsis: www/oops fix memory leak >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Thu Oct 21 14:30:21 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Dmitry Morozovsky >Release: FreeBSD 4-STABLE i386 >Organization: Cronyx Plus LLC (RiNet ISP) >Environment: System: FreeBSD 4-STABLE >Description: Patch provided fixes memry leak in oops' HTTP request parser. Patch has been approved by oops author and will be merged in next major version. >How-To-Repeat: >Fix: Index: Makefile =================================================================== RCS file: /home/ncvs/ports/www/oops/Makefile,v retrieving revision 1.33 diff -u -r1.33 Makefile --- Makefile 15 Oct 2004 12:13:38 -0000 1.33 +++ Makefile 21 Oct 2004 14:19:08 -0000 @@ -7,7 +7,7 @@ PORTNAME= oops PORTVERSION= ${OOPSVERSION} -PORTREVISION= 3 +PORTREVISION= 4 CATEGORIES= www MASTER_SITES= http://oops-cache.org/ DISTNAME= ${PORTNAME}-${OOPSVERSION} Index: files/patch-src_run__client.c =================================================================== RCS file: files/patch-src_run__client.c diff -N files/patch-src_run__client.c --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ files/patch-src_run__client.c 21 Oct 2004 14:19:08 -0000 @@ -0,0 +1,30 @@ + +$FreeBSD$ + +--- src/run_client.c.orig Thu Nov 20 12:57:16 2003 ++++ src/run_client.c Thu Oct 21 17:27:16 2004 +@@ -1158,7 +1158,7 @@ + + static int parse_http_request(char *src, struct request *rq, int so) + { +- char *p, *httpv; ++ char *p, *httpv, *s; + int http_major, http_minor; + + p = strchr(src, ' '); +@@ -1202,8 +1202,14 @@ + else if (!strcasecmp(src, "OPTIONS")) + rq->meth = METH_OPTIONS; + else { +- my_xlog(OOPS_LOG_SEVERE, "parse_http_request(): Unrecognized method `%s'.\n", src); ++ s = my_inet_ntoa(&rq->client_sa); ++ /* XXX Hack */ ++ if (strcasecmp(src, "SEARCH")) ++ my_xlog(OOPS_LOG_SEVERE, ++ "parse_http_request(): Unrecognized method `%s' from %s\n", ++ src, s ? s : "null"); + *p = ' '; ++ IF_FREE(rq->method); + return (-1); + } + IF_FREE(rq->method); >Release-Note: >Audit-Trail: >Unformatted: