From owner-freebsd-current@FreeBSD.ORG  Thu Jul 26 22:30:51 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7820B16A418
	for <freebsd-current@freebsd.org>; Thu, 26 Jul 2007 22:30:51 +0000 (UTC)
	(envelope-from des@des.no)
Received: from tim.des.no (tim.des.no [194.63.250.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 3683913C457
	for <freebsd-current@freebsd.org>; Thu, 26 Jul 2007 22:30:51 +0000 (UTC)
	(envelope-from des@des.no)
Received: from tim.des.no (localhost [127.0.0.1])
	by spam.des.no (Postfix) with ESMTP id B1A6D2089;
	Fri, 27 Jul 2007 00:30:47 +0200 (CEST)
X-Spam-Tests: AWL
X-Spam-Learn: disabled
X-Spam-Score: 0.0/3.0
X-Spam-Checker-Version: SpamAssassin 3.2.1 (2007-05-02) on tim.des.no
Received: from ds4.des.no (des.no [80.203.243.180])
	by smtp.des.no (Postfix) with ESMTP id 2A43E2085;
	Fri, 27 Jul 2007 00:30:47 +0200 (CEST)
Received: by ds4.des.no (Postfix, from userid 1001)
	id 11AEB84450; Fri, 27 Jul 2007 00:30:47 +0200 (CEST)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Mike Tancsa <mike@sentex.net>
References: <46337B06.9080102@ybb.ne.jp> <46338C0F.9000608@ybb.ne.jp>
	<4633932A.8080602@ybb.ne.jp> <86tzuxni1b.fsf@dwp.des.no>
	<200707061723.l66HNYSe037055@lava.sentex.ca>
	<86ir86hqhc.fsf@ds4.des.no>
	<200707262035.l6QKZtnd067391@lava.sentex.ca>
Date: Fri, 27 Jul 2007 00:30:46 +0200
In-Reply-To: <200707262035.l6QKZtnd067391@lava.sentex.ca> (Mike Tancsa's
	message of "Thu\, 26 Jul 2007 16\:35\:51 -0400")
Message-ID: <86abtihk6h.fsf@ds4.des.no>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: Takeharu KATO <takeharu1219@ybb.ne.jp>, freebsd-current@freebsd.org
Subject: Re: ichwd for ICH8
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Jul 2007 22:30:51 -0000

Mike Tancsa <mike@sentex.net> writes:
> Thanks!  On RELENG_6,

The patch is for CURRENT.

> /usr/src/sys/modules/ichwd/../../dev/ichwd/ichwd.c: In function ichwd_cle=
ar_noreboot':
> /usr/src/sys/modules/ichwd/../../dev/ichwd/ichwd.c:228: warning: implicit=
 declaration of function `device__printf'
> /usr/src/sys/modules/ichwd/../../dev/ichwd/ichwd.c:228: warning: nested e=
xtern declaration of `device__printf'
> *** Error code 1

Typo...

> ichwd module loaded
> ichwd0: <Intel ICH7 watchdog timer> on isa0
> ichwd0: unable to reserve GCS registers
> device_attach: ichwd0 attach returned 6

in ichwd_identify(), the ICH version test is wrong, it should be

-       if (id_p->version =3D=3D 2) {
+	if (id_p->version >=3D 6) {

> Same error on current
>
> ichwd module loaded
> ichwd0: <Intel ICH7 watchdog timer> on isa0
> ichwd0: ICH WDT present but disabled in BIOS or hardware
> device_attach: ichwd0 attach returned 6

Not the same error, but probably caused by the same mistake in
ichwd_identify()

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no