Date: Sat, 2 Feb 2002 20:09:08 -0500 From: Garance A Drosihn <drosih@rpi.edu> To: "Tim J. Robbins" <tim@robbins.dropbear.id.au>, Mike Barcroft <mike@FreeBSD.ORG> Cc: freebsd-standards@FreeBSD.ORG Subject: Re: pwd -L option Message-ID: <p0510141fb882398dfebf@[128.113.24.47]> In-Reply-To: <20020202210237.A2326@descent.robbins.dropbear.id.au> References: <20020130181638.A8510@descent.robbins.dropbear.id.au> <20020202032917.K10222@espresso.q9media.com> <20020202210237.A2326@descent.robbins.dropbear.id.au>
next in thread | previous in thread | raw e-mail | index | archive | help
At 9:02 PM +1100 2/2/02, Tim J. Robbins wrote: >Here's a new patch that I hope solves the problems you found with my >previous one. I have just a few comments, though... > > >On Sat, Feb 02, 2002 at 03:29:17AM -0500, Mike Barcroft wrote: > >> Style bug: ANSI-style prototypes. This is a problem because the rest >> of the file uses K&R-style. > >usage()'s prototype is also incorrect, then. It is: >void usage(void); > >It used to have a __P() around its argument list in 4.4BSD. Even then, >the 1st ed. K&R book says nothing about "void", which is usage()'s >return type. Is the so-called K&R style that is supposed to be >maintained documented anywhere? Actually, the freebsd project has decided to move away from K&R and are now writing updates to explicitly change source to ANSI. Some changes were just committed to the -current branch for many programs in /usr/bin, for instance. (just committed in the past 24 hours...) So, what would probably be the most appropriate here would be to have one update which ANSI-fies the source (just as far as the prototypes and routine-declarations are concerned), based on the rules in the most recent version of 'man 9 style' (which has also been changed over the last two weeks). Then have the update to add the new features and improvements. -- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-standards" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p0510141fb882398dfebf>