From owner-freebsd-hackers@FreeBSD.ORG Wed May 30 01:17:02 2012 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 14BDD1065674 for ; Wed, 30 May 2012 01:17:02 +0000 (UTC) (envelope-from bryan@shatow.net) Received: from secure.xzibition.com (secure.xzibition.com [173.160.118.92]) by mx1.freebsd.org (Postfix) with ESMTP id 68DA08FC16 for ; Wed, 30 May 2012 01:17:01 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=shatow.net; h=message-id :date:from:mime-version:to:cc:subject:references:in-reply-to :content-type; q=dns; s=sweb; b=Eow1EPogxHdlvPHnnNXVpOjCwwhzkLcO 6ogAAI7LM4WX52tAm8XD8mR7mFRe+tWWsxTwdsHRfjI5EaSBOinAna8OXmsaQ5bb wWnq+X1JRH+ek1wxXoXzaScYf3KmDDWo6LirLgD/G/MXvEAUPDr5yrbQ4LaPmdT9 6jd8D3IQZBY= DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=shatow.net; h=message-id :date:from:mime-version:to:cc:subject:references:in-reply-to :content-type; s=sweb; bh=w19nN9KRFbzcsVDS4aTuiVK8Lxa5GUaFTW7bOv wMXDQ=; b=B7iWP9meBX1+SZxl0bv0gLcMobTdJmGb3IRmwErAGW/l/rignEoFwH Ge01yJDPC1Gmj9fwsphKeKyPH03tgcvIz6irm8Phw5UrKi4dKBz+BXRkph/3BZmQ hh1M9R7W6YiN8tEXnv7s0RFkjh7Sxjofjq56u1xln8sTjQgqPKlB8= Received: (qmail 94258 invoked from network); 29 May 2012 20:16:59 -0500 Received: from unknown (HELO ?10.10.1.87?) (bryan@shatow.net@10.10.1.87) by sweb.xzibition.com with ESMTPA; 29 May 2012 20:16:59 -0500 Message-ID: <4FC57507.8070008@shatow.net> Date: Tue, 29 May 2012 20:16:55 -0500 From: Bryan Drewery User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: freebsd-hackers@freebsd.org References: <4FC2EBA5.8010500@shatow.net> In-Reply-To: <4FC2EBA5.8010500@shatow.net> X-Enigmail-Version: 1.4.1 OpenPGP: id=3C9B0CF9; url=http://www.shatow.net/bryan/bryan.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig25950D3E0AFAE1F9752655F5" Cc: ed@80386.nl, brucec@freebsd.org Subject: Re: script(1) broken on 7.4 - bin/146189 - r207453 fixes X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 May 2012 01:17:02 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig25950D3E0AFAE1F9752655F5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 5/27/2012 10:06 PM, Bryan Drewery wrote: > Hi, >=20 > As reported in bin/146189, script(1) was returning the wrong exit statu= s > sometimes. >=20 > The PR says that script(1) was broken by r205008/r205635, neither of > which are in 7-stable or releng/7.4. Yet it is broken on 7.4. >=20 > This is easily seen on 7.4: >=20 > # script -q /dev/null false; echo $? > 1 > # script -q /dev/null false; echo $? > 1 > # script -q /dev/null false; echo $? > 0 > # script -q /dev/null false; echo $? > 1 > # while true; do script -q /dev/null false && echo $? && break; ech= o > $?; done > 1 > 1 > <..snip..> > 1 > 0 >=20 > r207453 was MFC'd to 8-stable at the time, but not 7-stable, likely due= > to the changes attributed to causing the issue not having been on 7-sta= ble. >=20 > I am not entirely sure *how* script(1) broke on 7.4, but I have tested > r207453 on 7.4 and found that it Works For Me. >=20 > FWIW, could someone please MFC this to 7-stable? >=20 > The reason I ran into this is I am maintaining portupgrade, and working= > on ports/147242 and ports/131111. Both of which seem to be due to > script(1) returning the wrong exit status. >=20 > 7.x is EoL Feb 2013 [1]. Given that, and that script(1)'s return code > cannot be relied on for automated scripts. I am wondering what the > thoughts are on putting this patch out as an errata? >=20 > Regards, > Bryan Drewery >=20 > [1] http://www.freebsd.org/security/ >=20 It was reported to me that this is broken at least as far back as 4.7. I think the changes attributed in bin/146189 just made it come to light quicker. Still would be nice if this was MFC'd to 7-STABLE. Regards, Bryan Drewery --------------enig25950D3E0AFAE1F9752655F5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJPxXUHAAoJEG54KsA8mwz5Y5kP/icZXFJi5synZtWyIlSd29j1 kJ03FTPhwTUzbB6H+7glLmvJMgfQZl2NNPmu29RJBYRqWt8Wcbv8VxLxH2emCRJf MBmZu95gF8JEk31sU0igB+Gp0SPLuoWMoUaesr0UrKqeazvlxGY52HlUvZs5JJLU C4jQE9ymLjAnN4wshAAaM4BlNcu8hHQZ8tQZGxJhiz/f1BmSBBVUiAS2NJMfU+SV SINN1mv5zL3TPzudRy4tX/cD3RdCwYxQvRtDRae4Rpd7yOfa3Ggyb+rvPbY7TaSw gTQ5Tc5P6ytixw+0olHH2aPqf7YUgO2FvwWJvEOnJPGAMfOfHs3EdmwTVgWA+Rj6 9q1XzWQYsBBEUr9UPOyiUoMoGhLXo4B68z8Y//mF/oQxh2zKi2amGtL973KR/gkh NU+LPfVsBRYHONEL+UKFosTOQxTiNXGuUGE6jY0uKAKdn+YX8TczT/tB5Xx2Dw1r 9aZdaWUmF/ReR3ePJQf/IKZE4HFcQW6fEVtFEt5a1fN4ThRxBhb2WaCwmph9an9D /UPiAUpwA8i3jqKyKNjT7nU+xEAOCfVQl8xgPQaspR6rzt4PBmSq66swVdDnGA+a wOapOPB3rfV9apIzyAAvZXrY/u455ERSkdVgt/shJoJKSFBDZljTPtl4PL4gZgq3 KL35QOOAczhR2Y145M00 =WdNF -----END PGP SIGNATURE----- --------------enig25950D3E0AFAE1F9752655F5--