From owner-freebsd-stable@freebsd.org Sun Dec 4 13:53:33 2016 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F14B2C6440A for ; Sun, 4 Dec 2016 13:53:33 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id D97D4201 for ; Sun, 4 Dec 2016 13:53:33 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id D8D85C64409; Sun, 4 Dec 2016 13:53:33 +0000 (UTC) Delivered-To: stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D87EDC64408 for ; Sun, 4 Dec 2016 13:53:33 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7FD89200; Sun, 4 Dec 2016 13:53:33 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id uB4DrNjs056531 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sun, 4 Dec 2016 15:53:23 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua uB4DrNjs056531 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id uB4DrNBn056530; Sun, 4 Dec 2016 15:53:23 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 4 Dec 2016 15:53:23 +0200 From: Konstantin Belousov To: Andrey Chernov Cc: "stable@freebsd.org" , John Baldwin Subject: Re: if_cxgbev build error on -stable Message-ID: <20161204135323.GU54029@kib.kiev.ua> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Dec 2016 13:53:34 -0000 On Sun, Dec 04, 2016 at 04:23:00PM +0300, Andrey Chernov wrote: > It seems counter.h is included before systm.h where critical_* are declared. It is more weird, since sys/counter.h was added in the stable/10 merge, but the header is not used in the HEAD sources. It is indeed needed for stable/10 driver. critical_enter() pre-requisite for counter.h only exists on i386, which probably explains why John' build test did not catched it. I am preparing another MFC, so I committed the fix in r309529. > > On 04.12.2016 16:12, Andrey Chernov wrote: > > On recent i386 -stable I got: > > > > ... > > /usr/src/sys/modules/cxgbe/if_cxgbev/../../../dev/cxgbe/t4_vf.c -o t4_vf.o > > In file included from > > /usr/src/sys/modules/cxgbe/if_cxgbev/../../../dev/cxgbe/t4_vf.c:37: > > In file included from @/sys/counter.h:35: > > ./machine/counter.h:170:3: error: implicit declaration of function > > 'critical_enter' is invalid in C99 > > [-Werror,-Wimplicit-function-declaration] > > critical_enter(); > > ^ > > ./machine/counter.h:172:3: error: implicit declaration of function > > 'critical_exit' is invalid in C99 > > [-Werror,-Wimplicit-function-declaration] > > critical_exit(); > > ^ > > ./machine/counter.h:172:3: note: did you mean 'critical_enter'? > > ./machine/counter.h:170:3: note: 'critical_enter' declared here > > critical_enter(); > > ^ > > In file included from > > /usr/src/sys/modules/cxgbe/if_cxgbev/../../../dev/cxgbe/t4_vf.c:47: > > In file included from > > /usr/src/sys/modules/cxgbe/if_cxgbev/../../../dev/cxgbe/common/common.h:33: > > In file included from > > /usr/src/sys/modules/cxgbe/if_cxgbev/../../../dev/cxgbe/common/t4_hw.h:33: > > In file included from > > /usr/src/sys/modules/cxgbe/if_cxgbev/../../../dev/cxgbe/osdep.h:39: > > @/sys/systm.h:196:6: error: conflicting types for 'critical_enter' > > void critical_enter(void); > > ^ > > ./machine/counter.h:170:3: note: previous implicit declaration is here > > critical_enter(); > > ^ > > In file included from > > /usr/src/sys/modules/cxgbe/if_cxgbev/../../../dev/cxgbe/t4_vf.c:47: > > In file included from > > /usr/src/sys/modules/cxgbe/if_cxgbev/../../../dev/cxgbe/common/common.h:33: > > In file included from > > /usr/src/sys/modules/cxgbe/if_cxgbev/../../../dev/cxgbe/common/t4_hw.h:33: > > In file included from > > /usr/src/sys/modules/cxgbe/if_cxgbev/../../../dev/cxgbe/osdep.h:39: > > @/sys/systm.h:197:6: error: conflicting types for 'critical_exit' > > void critical_exit(void); > > ^ > > ./machine/counter.h:172:3: note: previous implicit declaration is here > > critical_exit(); > > ^ > > 4 errors generated. > > *** Error code 1 > > > > Stop. > > > > _______________________________________________ > freebsd-stable@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-stable > To unsubscribe, send any mail to "freebsd-stable-unsubscribe@freebsd.org"