From owner-freebsd-current Mon Apr 1 14:12:44 2002 Delivered-To: freebsd-current@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id 3305337B425 for ; Mon, 1 Apr 2002 14:12:33 -0800 (PST) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.2/8.12.2) with ESMTP id g31MCTYm023779; Mon, 1 Apr 2002 14:12:29 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.2/8.12.2/Submit) id g31MB3LJ023757; Mon, 1 Apr 2002 14:11:03 -0800 (PST) Date: Mon, 1 Apr 2002 14:10:59 -0800 From: "David O'Brien" To: Alexander Leidinger Cc: winter@jurai.net, freebsd-current@FreeBSD.org Subject: Re: cvs commit: ports/lang Makefile ports/lang/icc Makefile distinfo pkg-comment pkg-descr pkg-plist ports/lang/icc/files patch-include Message-ID: <20020401141059.B23489@dragon.nuxi.com> Reply-To: freebsd-current@FreeBSD.org References: <20020329202533.B74181@dragon.nuxi.com> <200203300903.g2U93l7S002763@Magelan.Leidinger.net> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.2.5i In-Reply-To: <200203300903.g2U93l7S002763@Magelan.Leidinger.net>; from Alexander@Leidinger.net on Sat, Mar 30, 2002 at 10:03:47AM +0100 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Mar 30, 2002 at 10:03:47AM +0100, Alexander Leidinger wrote: > On 29 Mär, David O'Brien wrote: > > >> > My patches to src/share/mk/ are here: > >> > > >> > ftp://ftp.jurai.net/users/winter/icc.mk.diff > >> > > >> > This allows you to set 'USE_ICC' and 'ICFLAGS' and build stuff. > > > > This is fine just to get things working. But please consider Doing It > > Right -- that being wrap the definitions of CC, CFLAGS, and PICFLAG with > > USE_ICC rather than strew USE_ICC all over the place. For instance: > > > > /usr/share/mk/sys.mk > > .if defined(USE_ICC) > > CC= icc > > .else > > CC= cc > > .endif > > - How do you want to solve the single suffix rules then? What is the problem with them? .c: ${CC} ${CFLAGS} ${LDFLAGS} -o ${.TARGET} ${.IMPSRC} CC and CFLAGS is used. > - Do we use ${LD} in every significant place? If we don't it is a bug -- send in a patch. But LD is `ld', does ICC come with its own linker? > - What about ports with "CC=${CC}" in CONFIGURE_ENV (they would break > in the USE_ICC case)? How would they?? CC=icc if you have USE_ICC defined. Either in /etc/make.conf or `make USE_ICC=yes'. It seems you do not realize the whole reason for "${CC}" rather than just "cc". > >> > -D__attribute__(x)= > >> > -D__GNUC__=2 > >> > >> Ok as a short term solution, but IMHO this should get solved in the > >> source. > > > > Totally agreed for defining __GNUC__. > > And the __attribute__ line is the reason why libc doesn't work. Explain "does not work". To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message