From owner-p4-projects@FreeBSD.ORG Thu Dec 7 14:23:13 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 40E9716A4A7; Thu, 7 Dec 2006 14:23:13 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DF2D716A416; Thu, 7 Dec 2006 14:23:12 +0000 (UTC) (envelope-from flag@newluxor.wired.org) Received: from mail.oltrelinux.com (krisma.oltrelinux.com [194.242.226.43]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0507B43CA3; Thu, 7 Dec 2006 14:22:19 +0000 (GMT) (envelope-from flag@newluxor.wired.org) Received: from newluxor.wired.org (ip-64-88.sn2.eutelia.it [83.211.64.88]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.oltrelinux.com (Postfix) with ESMTP id EBC0311AE43; Thu, 7 Dec 2006 15:23:03 +0100 (CET) Received: (from flag@localhost) by newluxor.wired.org (8.13.8/8.13.8/Submit) id kB7EMs85001985; Thu, 7 Dec 2006 15:22:54 +0100 (CET) (envelope-from flag) Date: Thu, 7 Dec 2006 15:22:54 +0100 From: Paolo Pisati To: Andre Oppermann Message-ID: <20061207142254.GA1195@tin.it> References: <200612062319.kB6NJgsq031755@repoman.freebsd.org> <20061207110225.GU32700@FreeBSD.org> <4578070A.2030609@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4578070A.2030609@freebsd.org> User-Agent: Mutt/1.4.2.2i X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at krisma.oltrelinux.com Cc: Gleb Smirnoff , Perforce Change Reviews , Paolo Pisati Subject: Re: PERFORCE change 111230 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2006 14:23:13 -0000 On Thu, Dec 07, 2006 at 01:20:26PM +0100, Andre Oppermann wrote: > Gleb Smirnoff wrote: > >On Wed, Dec 06, 2006 at 11:19:42PM +0000, Paolo Pisati wrote: > >P> http://perforce.freebsd.org/chv.cgi?CH=111230 > >P> > >P> Change 111230 by piso@piso_newluxor on 2006/12/06 23:19:06 > >P> > >P> To workaround a problem when an mbuf is bigger than MCLBYTES > >P> (and thus not handled by m_megapullup()), introduce & use > >P> m_jumbo16pullup() that uses 16k jumbo size cluster. > >P> > >P> This problem only showed up on traffic generated on a box with > >P> a nic tso enabled. > > > >Paolo, > > > >this isn't a fix. Another application will do write(,, 16k + 1) and > >m_jumbo16pullup() will fail again. Please backout it, it is a hack. > > > >We need to fix TSO in such way that real packets, that will be > >transmitted to wire, will be passed to pfil handlers. > > That is not possible. Then, after a discussion on irc, pull the plug on any present (and future) hackery & half-baked solution, and declare in kernel libalias incompatible with tso. bye -- Paolo Piso's first law: nothing works as expected!