From owner-p4-projects@FreeBSD.ORG  Wed Jul 18 13:01:47 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 9132B16A409; Wed, 18 Jul 2007 13:01:47 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 57D0C16A405
	for <perforce@freebsd.org>; Wed, 18 Jul 2007 13:01:47 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe07.swip.net [212.247.154.193])
	by mx1.freebsd.org (Postfix) with ESMTP id D5B0213C4B3
	for <perforce@freebsd.org>; Wed, 18 Jul 2007 13:01:46 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
X-Cloudmark-Score: 0.000000 []
Received: from [194.248.135.20] (account mc467741@c2i.net HELO laptop.lan)
	by mailfe07.swip.net (CommuniGate Pro SMTP 5.1.10)
	with ESMTPA id 550642673; Wed, 18 Jul 2007 15:01:45 +0200
From: Hans Petter Selasky <hselasky@c2i.net>
To: Brian Chu <chub@freebsd.org>
Date: Wed, 18 Jul 2007 15:01:48 +0200
User-Agent: KMail/1.9.5
References: <200707180820.l6I8KVJI066090@repoman.freebsd.org>
In-Reply-To: <200707180820.l6I8KVJI066090@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200707181501.48765.hselasky@c2i.net>
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 123680 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Jul 2007 13:01:47 -0000

On Wednesday 18 July 2007 10:20, Brian Chu wrote:
> http://perforce.freebsd.org/chv.cgi?CH=123680
>
> Change 123680 by chub@chub-msdosfs on 2007/07/18 08:19:38
>
> 	Few msdosfs compiling fixes that should've been caught earlier. 
> Eliminating ifndef/define/endif protection.
>
> Affected files ...
>
> .. //depot/projects/soc2007/chub-msdosfs2/sys/fs/msdosfs/bootsect.h#5 edit
> .. //depot/projects/soc2007/chub-msdosfs2/sys/fs/msdosfs/msdosfs_vfsops.c#4
> edit ..
> //depot/projects/soc2007/chub-msdosfs2/sys/geom/label/g_label_msdosfs.c#6
> edit
>

Hi,

I once had a division by zero in "fsck_msdosfs". I never persued it. Maybe 
there are some things you can check regarding scanning invalid volumes.

--HPS