From owner-svn-src-all@FreeBSD.ORG  Mon Aug  3 08:14:38 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7D08E106566C;
	Mon,  3 Aug 2009 08:14:38 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 567758FC21;
	Mon,  3 Aug 2009 08:14:38 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [65.122.17.41])
	by cyrus.watson.org (Postfix) with ESMTPS id 905BE46B32;
	Mon,  3 Aug 2009 04:14:37 -0400 (EDT)
Date: Mon, 3 Aug 2009 09:14:37 +0100 (BST)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Hans Petter Selasky <hselasky@c2i.net>
In-Reply-To: <200908030923.12867.hselasky@c2i.net>
Message-ID: <alpine.BSF.2.00.0908030909220.1507@fledge.watson.org>
References: <200908030923.12867.hselasky@c2i.net>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	Alfred Perlstein <alfred@freebsd.org>,
	src-committers@freebsd.org, Navdeep Parhar <nparhar@gmail.com>
Subject: Re: svn commit: r195960 - in head/sys/dev/usb: . controller input
 (regression patch)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Aug 2009 08:14:39 -0000


On Mon, 3 Aug 2009, Hans Petter Selasky wrote:

> Here is a patch to address the problem. Please test and report back. Works 
> fine over here.
>
> http://perforce.freebsd.org/chv.cgi?CH=166957
>
> MD5 (ukbd.c.diff) = 1e3c143942593b0ed4617d306a9d2ee2
>
> cd /usr/src/sys/dev/usb/input/
> cat ukbd.c.diff | patch

I'm a bit surprised the timed key repeat in this patch would work properly in 
DDB, as microtime(9) relies on interrupts firing for updated timestamps.  The 
availability of interrupts for polled input consumers varies, but in general 
this is not true (for example) at the DDB command prompt.  Does this code work 
correctly when time stands still?

Robert N M Watson
Computer Laboratory
University of Cambridge