From owner-freebsd-arm@FreeBSD.ORG Wed May 8 11:47:27 2013 Return-Path: Delivered-To: freebsd-arm@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 3A3C28F7 for ; Wed, 8 May 2013 11:47:27 +0000 (UTC) (envelope-from ray@freebsd.org) Received: from smtp.dlink.ua (smtp.dlink.ua [193.138.187.146]) by mx1.freebsd.org (Postfix) with ESMTP id EEE57966 for ; Wed, 8 May 2013 11:47:26 +0000 (UTC) Received: from terran (unknown [192.168.99.1]) (Authenticated sender: ray) by smtp.dlink.ua (Postfix) with ESMTPA id D49BAC4927; Wed, 8 May 2013 14:47:18 +0300 (EEST) Date: Wed, 8 May 2013 14:47:18 +0300 From: Aleksandr Rybalko To: Zbyszek Bodek Subject: Re: New PV entry allocator for pmap-v6.c Message-Id: <20130508144718.7ed355d7e0860a1abbe8955b@freebsd.org> In-Reply-To: <518A13D5.9030904@semihalf.com> References: <518545A0.5020107@semihalf.com> <518A13D5.9030904@semihalf.com> X-Mailer: Sylpheed 3.2.0 (GTK+ 2.24.6; amd64-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: freebsd-arm@FreeBSD.org, Alan Cox X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 May 2013 11:47:27 -0000 On Wed, 08 May 2013 10:59:01 +0200 Zbyszek Bodek wrote: > On 04.05.2013 19:30, Zbyszek Bodek wrote: > > Hello everyone, > > > > As a part of Semihalf work on Superpages support, > > we've made some pmap-v6.c improvements and clean-ups. > > > > We would like to start integrating our code to the mainline FreeBSD, > > therefore I'm happy to introduce the new PV entry allocator for > > pmap-v6.c ported from amd64/i386/mips. > > > > Alan Cox (alc) was so kind to review the code. > > > > If there are no objections, then we will commit this patch to the HEAD > > around Monday/Tuesday. > > > > Please check out the attachment for details. > > > > Hello again, > > Does anyone have any comments and/or remarks regarding the mentioned patch? > > I was testing it on the multicore ARMv7 machine however, it would be > good if someone test it on available ARMv6/ARMv7 platforms. > > Best regards > Zbyszek Bodek > > > _______________________________________________ > freebsd-arm@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-arm > To unsubscribe, send any mail to "freebsd-arm-unsubscribe@freebsd.org" Hi Zbyszek! I've not done deep review, but fail to compile it on fresh head: cc -c -O -pipe -march=armv6 -DARM_ARCH_6=1 -std=c99 -g -Wall -Wredundant-decls - Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winli ne -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -Wmissing-include -dirs -fdiagnostics-show-option -Wno-error-tautological-compare -Wno-error-empt y-body -Wno-error-parentheses-equality -nostdinc -I. -I/usr/home/ray/work/Free BSD/CLEAN/head/sys -I/usr/home/ray/work/FreeBSD/CLEAN/head/sys/contrib/altq -I/u sr/home/ray/work/FreeBSD/CLEAN/head/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_O PTION_HEADERS -include opt_global.h -ffreestanding -Werror /usr/home/ray/work$ FreeBSD/CLEAN/head/sys/arm/arm/pmap-v6.c /usr/home/ray/work/FreeBSD/CLEAN/head/sys/arm/arm/pmap-v6.c:908:9: error: no member named 'pvh_attrs' in 'struct md_page' pg->md.pvh_attrs &= ~(maskbits & (PVF_MOD | PVF_REF)); ~~~~~~^ /usr/home/ray/work/FreeBSD/CLEAN/head/sys/arm/arm/pmap-v6.c:1001:9: error: no member named 'pvh_attrs' in 'struct md_page' pg->md.pvh_attrs |= flags & (PVF_REF | PVF_MOD); ~~~~~~ ^ 18 errors total. Thanks a lot! P.S. how far from full ARM SMP support Semihalf now? WBW -- Aleksandr Rybalko