Date: Tue, 16 Sep 2014 21:30:50 +0400 From: Ruslan Makhmatkhanov <cvs-src@yandex.ru> To: "Jason E. Hale" <jhale@freebsd.org>, Adam Weinberger <adamw@adamw.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, ports-committers <ports-committers@freebsd.org>, jadm <jadm@dachev.info>, "Vanilla I. Shu" <vanilla@freebsd.org> Subject: Re: svn commit: r368241 - in head/sysutils: . jadm jadm/files Message-ID: <541873CA.60909@yandex.ru> In-Reply-To: <CAJE75NEfS2=iExysLF_oPFtkQ1tE3GOZXu-rwN4-6i3wGtnhCw@mail.gmail.com> References: <201409150227.s8F2ReuH083121@svn.freebsd.org> <CAJE75NE1p_mf4xHADQgoeKnmk_E7Wej9pfTsGJnPsJOj4PHWcw@mail.gmail.com> <539C903B-6DBA-42E3-8B99-76E3A92987A0@adamw.org> <CAJE75NEfS2=iExysLF_oPFtkQ1tE3GOZXu-rwN4-6i3wGtnhCw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Jason E. Hale wrote on 15.09.2014 20:05:
> On Mon, Sep 15, 2014 at 10:36 AM, Adam Weinberger <adamw@adamw.org> wrote:
>> On 15 Sep, 2014, at 3:50, Jason E. Hale <jhale@FreeBSD.org> wrote:
>>
>>> On Sun, Sep 14, 2014 at 10:27 PM, Vanilla I. Shu <vanilla@freebsd.org> wrote:
>>>>
>>>> +BUILD_DEPENDS= ${PYTHON_LIBDIR}/site-packages/paramiko/:${PORTSDIR}/security/py-paramiko \
>>>> + ${PYTHON_LIBDIR}/site-packages/netifaces.so:${PORTSDIR}/net/py-netifaces \
>>>> + ${PYTHON_LIBDIR}/site-packages/tabulate.py:${PORTSDIR}/devel/py-tabulate \
>>>> + ${PYTHON_LIBDIR}/site-packages/ipaddress.py:${PORTSDIR}/net/py-ipaddress
>>>
>>> This is a deprecated style of depending on other Python ports.
>>> Format should be:
>>> BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}paramiko>=0:${PORTSDIR}/security/py-paramiko
>>
>> I had no idea that format was deprecated. Perhaps an example could be added to the PHB or Uses/python.mk?
>>
> I'm sure the Python section of the PHB could use some attention. It
> still references the old USE_PYTHON and
> bsd.python.mk instead of USES=python and Uses/python.mk among other things.
>
> The format I mentioned is the one I have seen in most Python and Perl
> ports, however, Uses/python.mk has a mix
> of both styles. I guess "deprecated" was a little strong, that's more
> of an official word. "Not so common" might be
> more appropriate. To me, it looks cleaner and allows for version
> checking. Even still, ${PYTHON_SITELIBDIR}
> would be preferable to ${PYTHON_LIBDIR}/site-packages.
Putting my python@ hat on, I'd suggest to use this syntax instead:
${PYTHON_PKGNAMEPREFIX}paramiko>0:${PORTSDIR}/security/py-paramiko
The main point is to depend on package, not on specific file in the
filesystem.
But the actual problem is that this port, being a python script, make it
effectively useless when installing from a package. Because the
dependencies are defined as BUILD one, while it actually needs them to
run. So, they should be defined as RUN_DEPENDS only or, if the port
checks of their existence withing installation process, both on BUILD_
and RUN_DEPENDS.
--
Regards,
Ruslan
T.O.S. Of Reality
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?541873CA.60909>