From owner-svn-src-all@freebsd.org Tue Feb 26 17:20:17 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 77702151FDE1; Tue, 26 Feb 2019 17:20:17 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EFBA48F42D; Tue, 26 Feb 2019 17:20:16 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x1QHKALt046818; Tue, 26 Feb 2019 09:20:10 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id x1QHKAXr046817; Tue, 26 Feb 2019 09:20:10 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201902261720.x1QHKAXr046817@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r344487 - in head/sys: conf gnu/gcov In-Reply-To: To: Matthew Macy Date: Tue, 26 Feb 2019 09:20:10 -0800 (PST) CC: rgrimes@freebsd.org, Brooks Davis , "K. Macy" , Shawn Webb , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: EFBA48F42D X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.976,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2019 17:20:17 -0000 > This has zero impact on the licensing disposition of the kernel as > distributed as it is only used for test kernels. Tests compiled with > coverage instrumentation run much slower than even debug, one would never > ship this. Shit happens, mistakes get made, and sadly the consequences for someone could be pretty sad. > You are very much in the minority being more concerned with ideological > purity than minimizing the decline in relevance of FreeBSD, much less > striving to increase its relevance. I am not in the minority when it comes to GPL code anyplace in our base system, did you not read what core said, did you not read the suggested revised license guideline text? This gcov code has to eventually go, sooner or later. > On Tue, Feb 26, 2019 at 08:27 Rodney W. Grimes < > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > > On Mon, Feb 25, 2019 at 06:18:42PM -0800, Rodney W. Grimes wrote: > > > > > > The modest increase in activation energy for that task seems worth > > it > > > > > > for the short-term gains of reduced integration cost (this code > > will > > > > > > greatly improve our ZFS-on-Linux test coverage.) > > > > > > > > > > > > Rod rightly points out that we haven't accepted SPDX tags alone as > > > > > > license statements. The standard GPL v2.0 boiler plate should be > > added > > > > > > to this file along side the tag. > > > > > > > > > > I've copied the full copyright attribution that is in the > > > > > corresponding files on Linux. Is there some reason why FreeBSD > > > > > requires the files to be inflated with the full license text where > > the > > > > > original lacks it? > > > > > > > > I think for a few reasons, I doubt you copied the whole distribution > > > > that this file came from, as I am sure that distribution included > > > > a LICENSE file. Second if you actually read the GPL v2 documentation > > > > and follow what it says it says you must do this, just because some > > > > one else does not follow the rules of what the GPL v2 says does not > > > > give us to knowingling not do it. Third this is a particular > > dangerious > > > > area for BSD to be mixing a GPL code with its kernel, to my knowlege > > > > we have never had any gpl code in the kernel, no have we ever > > > > allowed it, but thats a seperate argument, that should be made. > > > > > > Would the arm64 DTS/DTB files count as "GPL code in the kernel?" > > > > > > I, too, would like less GPL in project, both in userland in kernel. > > > But, I can understand the desire for gcov. Note that I'm not > > > advocating either way that FreeBSD perform an action. ;) > > > > Didnt we just remove an inbase, compiling BSD licensed chunk of > > code called DRM and move it to ports. So if that was possible > > this should be very rapidly applied here and this issue goes away. > > > > I am still shaking my head over this one. Yes, there is some > > expediance to this. Also could it not live on a project > > branch? Like.. um.. the ZoL project branch? > > > > > Thanks, > > > Shawn Webb > > -- > > Rod Grimes > > rgrimes@freebsd.org > > -- Rod Grimes rgrimes@freebsd.org