From nobody Wed Jul 1 04:16:32 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gqmtD2fCHz6kZG4; Wed, 01 Jul 2026 04:16:36 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gqmtD22Fcz3v1l; Wed, 01 Jul 2026 04:16:36 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782879396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2OGAAgs+yiI79efvN9yvYCIWKpETOU5J+aOX+JNGZOo=; b=rI60l8EFsyQRaRyo9CsElfeKwwU/bRmgW5EjUhA02nQ5+Jlq/kPgeTefEnew1OikomRPhI rk6JfbaLO9mP8dghu6zDDLLXvHm3PK2xoKD9sGHtyS3dhM6bMhkRLW6meq67WfLE38P3Jd QQwt1IpJsefgDoSqHZXxAXYkhgauZmNLKGMShNTKlr6o9+hbOu6f81Pf+up19uhFoNvN6q B2yYmbcgIQ+QgEToqLRSSNlX9ZXjnvXX61lwtQEOdrDtTXSBCNdTj7jPMX4yrPfa7HAA1X wqCB4Pe8ip4/76Apq1UrkkZLEtsSxTOiPYVz51E8buV6cVkK36g01Wfh8vNhQw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782879396; a=rsa-sha256; cv=none; b=J7D0/34RSXmDRByMjW1mJKSPUF9QrnE1zKTLLHWvkG7o5uG3WHTWBn4wqLW0S2x8EVSwWZ KVKEC9xlI0RhzJNZq9VZbmTCntbiM904QyfJHlrjvtC5zCXIgjvK8q47Me2EG0vEfxU4LJ X/25kyWxgXFs3c3Wh8yKVSJhJOHDV8/pUynsr75QTwxhaXj9T7fqDh4EQYpTuhuvGwn0J9 BP1kWy/stkE5jRAhiYaMQeXEW5Ksi7IPe4ctFfQxXfoHmEQMLi3wl7FSvBHaaLFZFBLVz+ UFIya0YEFv2Xcxtwwdezgc8gWRbl5STKImt8lvJlpnj6NhDSw8x/fPJoUpll6g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782879396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2OGAAgs+yiI79efvN9yvYCIWKpETOU5J+aOX+JNGZOo=; b=NX00i/CQjj9rK67mB2jQFtnD86SKfgE/271CcbcjUj8t2BT1y0uEsmEODSitgkP7M/oQuy oWw3bCAU7Home6crEJP6/+Asv91OUVMAGTL+JGp/ZzVh+RCEelFZ3DVxU99x8rIsMqBswO 2/DMjmw+v0t9NePzSFVF/Xa8pG4tPXHJwOuTFPUPkjnyp9NfQ3bVQsrODSmaxYj1ugVB38 Yk61LpOXzkpZcFybQBUtJozyKaTsynxSeg7wWDXHBLlirXpDDepeH4t0jnhMkItyodzi3/ o+5BxWtAUEEl+KzMr9jRS9efx8kajZ8qqiezY8Uro61isYee7sN4tVwC/M66mw== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gqmtC2XnKz12sV; Wed, 01 Jul 2026 04:16:35 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Tue, 30 Jun 2026 21:16:32 -0700 From: Gleb Smirnoff To: Michael Tuexen Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Timo =?iso-8859-1?Q?V=F6lker?= Subject: Re: git: d6c4cea7740d - main - loopback: improve checksum offloading Message-ID: References: <6a40fe36.39b1d.3aea7fb1@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6a40fe36.39b1d.3aea7fb1@gitrepo.freebsd.org> On Sun, Jun 28, 2026 at 10:57:58AM +0000, Michael Tuexen wrote: M> commit d6c4cea7740d5c5c673a06ba37e4f1bdcddb2ece M> Author: Timo Völker M> AuthorDate: 2026-06-28 10:50:15 +0000 M> Commit: Michael Tuexen M> CommitDate: 2026-06-28 10:50:15 +0000 M> M> loopback: improve checksum offloading M> M> * Allow disabling IFCAP_RXCSUM_IPV6 or IFCAP_TXCSUM_IPV6. M> * Do not pretend the checksum is correct by setting the LO_CSUM_SET M> flags if IFCAP_RXCSUM_IPV6 or IFCAP_RXCSUM is enabled. Instead, M> remove the LO_CSUM_SET flags (in case they have been set somehow) M> if IFCAP_RXCSUM_IPV6 or IFCAP_RXCSUM is disabled. M> * Do not unset the transmit checksum offload flags LO_CSUM_FEATURES or M> LO_CSUM_FEATURES6 since they now have a meaning for the receive path. M> M> Reviewed by: glebius, pouria, tuexen M> Okayed by: bz M> MFC after: 1 week M> Differential Revision: https://reviews.freebsd.org/D57518 I'm guessing this change is responsible for breaking the netinet/ip_reass_test. The tests inject packets to localhost. Now all subtests fail, but after each test that creates single packet I see in 'netstat -sp ip' increase in 'bad header checksums'. Can you please check this? -- Gleb Smirnoff