From owner-svn-src-all@FreeBSD.ORG Fri Dec 12 20:38:44 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9AFED7D6; Fri, 12 Dec 2014 20:38:44 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 71304EB5; Fri, 12 Dec 2014 20:38:44 +0000 (UTC) Received: from ralph.baldwin.cx (pool-173-70-85-31.nwrknj.fios.verizon.net [173.70.85.31]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 6FE5FB946; Fri, 12 Dec 2014 15:38:43 -0500 (EST) From: John Baldwin To: John-Mark Gurney Subject: Re: svn commit: r275732 - in head: etc/mtree share/man/man4 share/man/man7 share/man/man9 sys/conf sys/crypto/aesni sys/crypto/via sys/geom/eli sys/libkern sys/mips/rmi/dev/sec sys/modules/aesni sys/mo... Date: Fri, 12 Dec 2014 15:38:41 -0500 Message-ID: <3059144.OhW84ild8L@ralph.baldwin.cx> User-Agent: KMail/4.14.2 (FreeBSD/10.1-STABLE; KDE/4.14.2; amd64; ; ) In-Reply-To: <20141212203517.GE25139@funkthat.com> References: <201412121956.sBCJucpj048475@svn.freebsd.org> <1533978.vC7tcjiHLN@ralph.baldwin.cx> <20141212203517.GE25139@funkthat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 12 Dec 2014 15:38:43 -0500 (EST) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Dec 2014 20:38:44 -0000 On Friday, December 12, 2014 12:35:17 PM John-Mark Gurney wrote: > John Baldwin wrote this message on Fri, Dec 12, 2014 at 15:23 -0500: > > On Friday, December 12, 2014 07:56:38 PM John-Mark Gurney wrote: > > > Author: jmg > > > Date: Fri Dec 12 19:56:36 2014 > > > New Revision: 275732 > > > URL: https://svnweb.freebsd.org/changeset/base/275732 > > > > > > Log: > > > Add some new modes to OpenCrypto. These modes are AES-ICM (can be > > > used > > > for counter mode), and AES-GCM. Both of these modes have been added > > > to > > > the aesni module. > > > > > > Obtained from: p4: //depot/projects/opencrypto > > > Relnotes: yes > > > Sponsored by: FreeBSD Foundation > > > Sponsored by: NetGate > > > > No reviewers? (I thought FF projects required a reviewer?) Were you not > > able to get other folks to review this when you asked? > > > > With crypto involved, it would seem like a good idea to have run this by > > secteam if you hadn't. (If you did, something like 'Silence from: > > secteam' in the commit log would have let us know you tried and didn't > > get any feedback). > > Sorry, I did get reviewers for specific parts of the project... But > they were third party reviewers... > > Watson Ladd did the software AES review, and Mike Hamburg did the > AES-NI review. > > Also, I posted an earlier version of this patch to -security and > -current over a month ago, and didn't get any significant responses... > > Sorry for not including that in the commit. Want me to do a null > commit to record it? or? No, I don't think it's worth a null commit over. I think noting even external reviewers is probably a good idea for future reference though. Thanks! -- John Baldwin