From nobody Thu Jul 10 14:42:46 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bdHd253PSz6187R; Thu, 10 Jul 2025 14:42:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bdHd228RCz4Mb4; Thu, 10 Jul 2025 14:42:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752158566; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uTtocf1geyfZmx3n4GSMDlX8PrJf+tI8SggfrzX/az0=; b=mR2KgBgY/xlZQmNaTeV0e4X0H/4ise+RHFp67Z8ovdIn4YM0FdlPfotFhxKFVU5fUcZRHj xJnksG7neGEwujLWnE4K2qOG0KRsQc/ISTL5IBWTZG7T4w8ktfk/zeEfmuszqcmS6iPznX NQNjVN98Jnup18xkH69XwS6O+LsPq3n3wFl1jJzRXHuPGpzvOwpxI0teWAytjXiReHcOzN z+T+Waxizm3TLXt8Bc9NXiT67gcHwxzZkABo5v2Zu5Wix8BDBvVsN1tmsHMY+uGZFdpAcr UIQ7NUT3YFfm1mlKvC4c6MVoA7mkYx0tjrqxElNb5uyAdfpkywI0dDZmaYqtlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752158566; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uTtocf1geyfZmx3n4GSMDlX8PrJf+tI8SggfrzX/az0=; b=DRfpU22LSjrOfzfIhhW5Gc25y0qcCEgL2PZycA2x6OO78j7DVsEdqsbMB6/61Je1b4nhIW l7Ml5YhpAmiIC2ybI+aIw9JP4nh6xoDDEXjfSGmr5vgAAokExjiVIixH4U+IfMmuRO7UEF 8JxQGxvwp2YLxTptzfM6h3x+0ZCjCgAhe24eGT3rC/1TOyHn1yHr45wyg1WG+dA2ZdcmGs RwSppzJhwcceeK03UN3eIO8yfrelkC3z91wZMCi6mVgDzpddfUKhYoUj6LnrS2FeyF45P5 CXD/WA+S08p/lridv0b94MyPxLCPB5svOlojLf31BJ0lY1fPIZaVX1Ow/PUMWQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1752158566; a=rsa-sha256; cv=none; b=xv/Pc0OQBTPlEd4yB6F6wKM7taCcphhqc+G/cYuNlKNcBgtzfy/Xk1mhvoUTYXwG9fgovQ mbtLF9SRrWyp5OvzZRlaBVG49ivbX6YSBO2HgXMShVIJ2ag79rTGwCZe50Rain+2LAj3E6 hqHblKCVnRhq0qXy191eZQaEyBWBOWs4H7OO9rZfrabClzAHDgK/+NtEjhtEEgeowPKXrj YbmQAx2fnAdNZeVymAGsat0oD3B8UkCDhxLl9vcB3IP2VmS2YfNheJcztHIXdZSS/+dsRI 6Ars9wqpdqfCvGKGqEBrI1WkeV+sO5f2+hecA7uHADzOJOKKtriw4c5xNsOZRQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bdHd21VM1z1BD9; Thu, 10 Jul 2025 14:42:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56AEgkCt015006; Thu, 10 Jul 2025 14:42:46 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56AEgkkG015003; Thu, 10 Jul 2025 14:42:46 GMT (envelope-from git) Date: Thu, 10 Jul 2025 14:42:46 GMT Message-Id: <202507101442.56AEgkkG015003@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 1b7d0c2ee947 - main - in_pcb: add in_pcbrele_rlock() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1b7d0c2ee94748814a6c7943806ab8160e65a6f5 Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=1b7d0c2ee94748814a6c7943806ab8160e65a6f5 commit 1b7d0c2ee94748814a6c7943806ab8160e65a6f5 Author: Konstantin Belousov AuthorDate: 2025-07-03 10:36:58 +0000 Commit: Konstantin Belousov CommitDate: 2025-07-10 14:42:27 +0000 in_pcb: add in_pcbrele_rlock() The helper that derefs and rlocks the provided inp. Returns false if inp is still usable. Reviewed by: glebius, markj Sponsored by: Nvidia networking Differential revision: https://reviews.freebsd.org/D51143 --- sys/netinet/in_pcb.c | 17 +++++++++++++++++ sys/netinet/in_pcb.h | 1 + 2 files changed, 18 insertions(+) diff --git a/sys/netinet/in_pcb.c b/sys/netinet/in_pcb.c index bccd4b84561a..dbe48242381d 100644 --- a/sys/netinet/in_pcb.c +++ b/sys/netinet/in_pcb.c @@ -1744,6 +1744,23 @@ in_pcbrele(struct inpcb *inp, const inp_lookup_t lock) in_pcbrele_rlocked(inp) : in_pcbrele_wlocked(inp)); } +/* + * Dereference and rlock inp, for which the caller must own the + * reference. Returns true if inp no longer usable, false otherwise. + */ +bool +in_pcbrele_rlock(struct inpcb *inp) +{ + INP_RLOCK(inp); + if (in_pcbrele_rlocked(inp)) + return (true); + if ((inp->inp_flags & INP_FREED) != 0) { + INP_RUNLOCK(inp); + return (true); + } + return (false); +} + /* * Unconditionally schedule an inpcb to be freed by decrementing its * reference count, which should occur only after the inpcb has been detached diff --git a/sys/netinet/in_pcb.h b/sys/netinet/in_pcb.h index 57cf15ca37fc..9e0618e87601 100644 --- a/sys/netinet/in_pcb.h +++ b/sys/netinet/in_pcb.h @@ -681,6 +681,7 @@ void in_pcbref(struct inpcb *); bool in_pcbrele(struct inpcb *, inp_lookup_t); bool in_pcbrele_rlocked(struct inpcb *); bool in_pcbrele_wlocked(struct inpcb *); +bool in_pcbrele_rlock(struct inpcb *inp); typedef bool inp_match_t(const struct inpcb *, void *); struct inpcb_iterator {