From owner-freebsd-bugs@FreeBSD.ORG  Tue Apr 16 18:00:01 2013
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id E3522D99
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Tue, 16 Apr 2013 18:00:01 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id D64B3CC4
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Tue, 16 Apr 2013 18:00:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r3GI01Ci015112
 for <freebsd-bugs@freefall.freebsd.org>; Tue, 16 Apr 2013 18:00:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r3GI01KT015111;
 Tue, 16 Apr 2013 18:00:01 GMT (envelope-from gnats)
Date: Tue, 16 Apr 2013 18:00:01 GMT
Message-Id: <201304161800.r3GI01KT015111@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: dfilter@FreeBSD.ORG (dfilter service)
Subject: Re: kern/177759: commit references a PR
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Apr 2013 18:00:02 -0000

The following reply was made to PR kern/177759; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/177759: commit references a PR
Date: Tue, 16 Apr 2013 17:50:40 +0000 (UTC)

 Author: dim
 Date: Tue Apr 16 17:50:20 2013
 New Revision: 249557
 URL: http://svnweb.freebsd.org/changeset/base/249557
 
 Log:
   MFC r249449:
   
   Fix undefined behaviour in several gpio_pin_setflags() routines (under
   sys/arm and sys/mips), squelching the clang 3.3 warnings about this.
   
   Noticed by:	tinderbox and many irate spectators
   Submitted by:	Luiz Otavio O Souza <loos.br@gmail.com>
   PR:		kern/177759
 
 Modified:
   stable/8/sys/mips/atheros/ar71xx_gpio.c
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/mips/   (props changed)
 
 Modified: stable/8/sys/mips/atheros/ar71xx_gpio.c
 ==============================================================================
 --- stable/8/sys/mips/atheros/ar71xx_gpio.c	Tue Apr 16 17:47:13 2013	(r249556)
 +++ stable/8/sys/mips/atheros/ar71xx_gpio.c	Tue Apr 16 17:50:20 2013	(r249557)
 @@ -225,8 +225,8 @@ ar71xx_gpio_pin_setflags(device_t dev, u
  	if (i >= sc->gpio_npins)
  		return (EINVAL);
  
 -	/* Filter out unwanted flags */
 -	if ((flags &= sc->gpio_pins[i].gp_caps) != flags)
 +	/* Check for unwanted flags. */
 +	if ((flags & sc->gpio_pins[i].gp_caps) != flags)
  		return (EINVAL);
  
  	/* Can't mix input/output together */
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"