From owner-freebsd-ports-bugs@freebsd.org Fri Oct 20 07:55:37 2017 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CC1CCE522A0 for ; Fri, 20 Oct 2017 07:55:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AC79B6C914 for ; Fri, 20 Oct 2017 07:55:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v9K7tbAS080751 for ; Fri, 20 Oct 2017 07:55:37 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 223125] x11/kdelibs4: 'large' is no longer a valid msdosfs mount option in head after r319735 Date: Fri, 20 Oct 2017 07:55:37 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: avg@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kde@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Oct 2017 07:55:37 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D223125 Bug ID: 223125 Summary: x11/kdelibs4: 'large' is no longer a valid msdosfs mount option in head after r319735 Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: kde@FreeBSD.org Reporter: avg@FreeBSD.org Flags: maintainer-feedback?(kde@FreeBSD.org) Assignee: kde@FreeBSD.org x11/kdelibs4 has a patch, patch-solid_solid_backends_hal_halstorageaccess.c= pp, that adds 'large' option to msdosfs (aka vfat) mount command if that option= is reported as supported by hal. The option was removed in head in commit base r319735 after completion of t= he ino64 project. hal still advertises 'large' as a valid option for all version of FreeBSD, = see bug #221709. Conditionally removing that option in either hal or kde would work. While I am here I would like to point out that patch-solid_solid_backends_hal_halstorageaccess.cpp contains a bug. It adds this line: if ( halOptions.contains("-L=3D") && (cType =3D getenv("LC_ALL")) || (c= Type =3D getenv("LC_CTYPE")) || (cType =3D getenv("LANG")) ) it can be written in a compact form as if ( A && B || C || D ) which equivalent to if ( (A && B) || C || D ) but it really should be if ( A && (B || C || D) ) --=20 You are receiving this mail because: You are the assignee for the bug.=