From owner-svn-src-head@FreeBSD.ORG Sun Jul 25 20:19:35 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3A7741065673; Sun, 25 Jul 2010 20:19:35 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 856478FC18; Sun, 25 Jul 2010 20:19:34 +0000 (UTC) Received: by fxm13 with SMTP id 13so6319726fxm.13 for ; Sun, 25 Jul 2010 13:19:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=4/xxEcb7ELmonPD+ek1aoSr6cGjHvijbymJykpQn/MI=; b=gBYbZqzpDqdXqtXFtuf8pMiFNYEKuaDUi14QpmK1gczeUJTiiJA/StZhG4rMpksdy4 XotW2xPq4j9SqtqiZjyuYy34tiZhYTfg38kqLz1rbwpGqImZfbOomIJVdHj6WUVSX41e 7yZGqxiz+t/Y9a21iAz7Hox36pwcBw1PmTMBM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=jEKVaHBqTxR98zgn2Bq6m7QZC6gkuQJHFXmg+mMBCIHIcqB55sCQ786041DKCNoq52 lZy8IvS/80yB2mi7STmfwB71wwzr+5/OCdD5IZedehJzJha4pfHFQ/CuJv917iXHfm9e IL2goQgjJo50aBuIE/kBMnkctexfjQ18Ki+YM= Received: by 10.223.122.195 with SMTP id m3mr5483212far.86.1280089173333; Sun, 25 Jul 2010 13:19:33 -0700 (PDT) Received: from mavbook2.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id a9sm1069133faa.3.2010.07.25.13.19.32 (version=SSLv3 cipher=RC4-MD5); Sun, 25 Jul 2010 13:19:32 -0700 (PDT) Sender: Alexander Motin Message-ID: <4C4C9C0A.2030703@FreeBSD.org> Date: Sun, 25 Jul 2010 23:18:18 +0300 From: Alexander Motin User-Agent: Thunderbird 2.0.0.23 (X11/20091212) MIME-Version: 1.0 To: Scott Long References: <201007251543.o6PFhrHp088504@svn.freebsd.org> <79B77F13-9802-4007-A565-28B76A0AAA88@samsco.org> In-Reply-To: <79B77F13-9802-4007-A565-28B76A0AAA88@samsco.org> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r210471 - in head: sbin/camcontrol sys/cam sys/cam/ata sys/cam/scsi sys/dev/ahci sys/dev/ata sys/dev/mvs sys/dev/siis sys/geom X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Jul 2010 20:19:35 -0000 Hi. Scott Long wrote: > I'm tired of CCB structure sizes changing willie nillie, whether in a CURRENT branch or not. This should have been a new CCB, not a add-on to an existing CCB. All your patch does it break binary compatibility. This only changes size of "struct ccb_pathinq", other structures are not affected, so driver ABI breakage is minimal. We did the same when adding maxio field. Do you think I should remake this? PS: Actually it was your words: "I think that there are reasonable ways to address this though, by having CAM SIMs provide a bit more information in their PATH_INQ response." > On Jul 25, 2010, at 9:43 AM, Alexander Motin wrote: >> Author: mav >> Date: Sun Jul 25 15:43:52 2010 >> New Revision: 210471 >> URL: http://svn.freebsd.org/changeset/base/210471 >> >> Log: >> Export PCI IDs of ATA/SATA controllers through CAM and ata(4) layers to >> GEOM. This information needed for proper soft-RAID's on-disk metadata >> reading and writing. >> >> Modified: >> head/sbin/camcontrol/camcontrol.c >> head/sys/cam/ata/ata_da.c >> head/sys/cam/cam_ccb.h >> head/sys/cam/scsi/scsi_cd.c >> head/sys/cam/scsi/scsi_da.c >> head/sys/dev/ahci/ahci.c >> head/sys/dev/ata/ata-all.c >> head/sys/dev/ata/ata-disk.c >> head/sys/dev/mvs/mvs.c >> head/sys/dev/siis/siis.c >> head/sys/geom/geom_disk.c >> head/sys/geom/geom_disk.h -- Alexander Motin