From owner-svn-src-head@freebsd.org Thu Nov 23 03:41:39 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D7478DC0EF7; Thu, 23 Nov 2017 03:41:39 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-qt0-x234.google.com (mail-qt0-x234.google.com [IPv6:2607:f8b0:400d:c0d::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8E8537994B; Thu, 23 Nov 2017 03:41:39 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-qt0-x234.google.com with SMTP id w10so14442491qtb.10; Wed, 22 Nov 2017 19:41:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=048jiexJCgnSc6gjTqE9KfQk/odWOuXN3nw1FC2nfmQ=; b=HJXZurpYvnTtlGy5JrUfZJ6CFliPiXIG8z6rhPzjLxQGQjRQBWff+56plb1fSdafsS rZcCdO+VkjuL5diVOE5+MXboUYSYcAVcn6ZuiIRjNMHG+8rb4VZCz24XN4n1ENojxdmd 0L6uTnnnds/Gr/djPc0wUjggEH7b+H6VQMi/ZE5R2YWeSEgBOk5oR8wR/w52rKNOu7E3 +Nuw7LPeUvkR0ryQjdSVmMNkOObdUhpY4EGjzRv2HHnVzA2BOkkjfJHBgaqcAzl1kzA6 QWVtDtPrPCWcwvmfszgceXKeRTyuUiVbG4HYMnpq+zsVWVF9kKu3mP4fd4W7A0pswsUU zuGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=048jiexJCgnSc6gjTqE9KfQk/odWOuXN3nw1FC2nfmQ=; b=acZ8sQUGNW+57DShMf2FEx714BXh+XJfabGH4WPLkhOCVdzg943uucjTFwx3CkycN2 I4qEC2GIWQnCaHx6DraQoNDzN15y4wcO++5Vn1gHRjJteafLtqQtC+x6WukiUUNvPHAH rR+e1S1kHPa3yckx/QxqlWzUVLj/YKfOKVJ2b9AL0+ijaleiDOYruiNhegJi7M11R4vT ZSMr+YiZwokxUNtfL4HuKEBIlU3wWESKxzm3FeC2PrkTZGXVjs48NQXBMhUOBK15dQVY 7DOp28Zi254kA/7FNlEU1gplpOFUmWLrVuetPQhVt/xydSWxx1DgCPVjPyPDheeyuATl bmcQ== X-Gm-Message-State: AJaThX6hOR5+rYCxYBudyQV1kHknYeghvbq+wRyERlEL4zLIuUa/mZEW v94CtAsQE3WRcO4wvR2YepQSHgk2DfBVIUyxo00xEQ== X-Google-Smtp-Source: AGs4zMayVyexiWc+pf/DuZNrke5YFmR1tDRaG162AJ1HzGY1iAkh9jNJ82WnP3++2ztFcdCszgsSbCzf60DVEX7ab64= X-Received: by 10.200.23.61 with SMTP id w58mr1609978qtj.341.1511408498610; Wed, 22 Nov 2017 19:41:38 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.54.106 with HTTP; Wed, 22 Nov 2017 19:41:38 -0800 (PST) In-Reply-To: <20171123031720.4iyoyvfyhxsltexw@mutt-hbsd> References: <201711222204.vAMM44FW023951@repo.freebsd.org> <20171123031720.4iyoyvfyhxsltexw@mutt-hbsd> From: Mateusz Guzik Date: Thu, 23 Nov 2017 04:41:38 +0100 Message-ID: Subject: Re: svn commit: r326107 - in head/sys: kern sys To: Shawn Webb Cc: Mateusz Guzik , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Nov 2017 03:41:39 -0000 oops, fixed in r326107 On Thu, Nov 23, 2017 at 4:17 AM, Shawn Webb wrote: > On Wed, Nov 22, 2017 at 10:04:04PM +0000, Mateusz Guzik wrote: > > Author: mjg > > Date: Wed Nov 22 22:04:04 2017 > > New Revision: 326107 > > URL: https://svnweb.freebsd.org/changeset/base/326107 > > > > Log: > > locks: pass the found lock value to unlock slow path > > > > This avoids an explicit read later. > > > > While here whack the cheaply obtainable 'tid' argument. > > > > Modified: > > head/sys/kern/kern_mutex.c > > head/sys/kern/kern_rwlock.c > > head/sys/kern/kern_sx.c > > head/sys/sys/mutex.h > > head/sys/sys/rwlock.h > > head/sys/sys/sx.h > > This breaks ZFS: > https://gist.github.com/lattera/93faa9c47ccc985ebda039ab31641c2c > > Thanks, > > -- > Shawn Webb > Cofounder and Security Engineer > HardenedBSD > > GPG Key ID: 0x6A84658F52456EEE > GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE > -- Mateusz Guzik