From owner-freebsd-current Sun Mar 1 04:59:00 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id EAA09593 for freebsd-current-outgoing; Sun, 1 Mar 1998 04:59:00 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from brane.digs.iafrica.com (brane.digs.iafrica.com [196.7.162.25]) by hub.freebsd.org (8.8.8/8.8.8) with SMTP id EAA09585 for ; Sun, 1 Mar 1998 04:58:55 -0800 (PST) (envelope-from iang@digs.iafrica.com) Received: from digs.iafrica.com [127.0.0.1] by brane.digs.iafrica.com with esmtp (Exim 1.71 #1) id 0y98KQ-0001ZC-00; Sun, 1 Mar 1998 14:58:50 +0200 To: current@FreeBSD.ORG Subject: Duplicate cases in /usr/src/sys/pci/pcisupport.c X-Attribution: BOFH Date: Sun, 01 Mar 1998 14:58:49 +0200 From: Ian Freislich Message-Id: Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Hi Noticed this when I tried to compile my kernel this afternoon: cc -c -O -pipe -Wreturn-type -Wcomment -Wredundant-decls -Wimplicit -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wuninitialized -nostdinc -I- -I. -I../.. -I../../../include -DKERNEL -include opt_global.h ../../pci/pcisupport.c ../../pci/pcisupport.c: In function `chipset_probe': ../../pci/pcisupport.c:217: duplicate case value ../../pci/pcisupport.c:207: this is the first entry for that value ../../pci/pcisupport.c:219: duplicate case value ../../pci/pcisupport.c:209: this is the first entry for that value ../../pci/pcisupport.c:223: duplicate case value ../../pci/pcisupport.c:211: this is the first entry for that value ../../pci/pcisupport.c:225: duplicate case value ../../pci/pcisupport.c:213: this is the first entry for that value ../../pci/pcisupport.c: In function `vga_probe': ../../pci/pcisupport.c:826: warning: declaration of `type' shadows a parameter ../../pci/pcisupport.c:1090: warning: return discards `const' from pointer target type Looking in the file: @207: case 0x71008086: return ("Intel 82439TX System Controller (MTXC)"); @217: case 0x71008086: return ("Intel 82439TX PCI cache memory controller"); I suppose this would have a bad effect on things. I'm not sure if this part number is both of the things this code suggests it is. -- igf (Ian Freislich) http://copernicus.iafrica.com/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message