From owner-cvs-all@FreeBSD.ORG Fri Feb 6 19:21:55 2009 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5A4D91065670 for ; Fri, 6 Feb 2009 19:21:55 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5]) by mx1.freebsd.org (Postfix) with ESMTP id E48018FC2B for ; Fri, 6 Feb 2009 19:21:54 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 16214 invoked by uid 399); 6 Feb 2009 19:21:45 -0000 Received: from localhost (HELO ?192.168.0.19?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 6 Feb 2009 19:21:45 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <498C8DC5.2080709@FreeBSD.org> Date: Fri, 06 Feb 2009 11:21:41 -0800 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) MIME-Version: 1.0 To: Doug Barton , ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org References: <200902050840.n158eurh096951@repoman.freebsd.org> <498B64FE.9080101@FreeBSD.org> <20090206122613.GB2720@kyuzo.dunkelkammer.void> In-Reply-To: <20090206122613.GB2720@kyuzo.dunkelkammer.void> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Subject: Re: cvs commit: ports/mail/dkim-milter/files milter-dkim.sh.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Feb 2009 19:21:55 -0000 Stefan Walter wrote: > Doug Barton, 05.02.09, 23:15h CET: > >> The milterdkim_flags default assignment is still wrong, it should be >> done as the _alg default is done above it. Also, it's not necessary to >> set empty defaults for anything except the _enable option. By default >> rc.d handles empty variables appropriately. > > Hm...it seems like yesterday was one of those days when I shouldn't have > committed anything... > > Thanks for the hint, I'll fix it as soon as I get to it. No worries. The current version isn't "bad," just needlessly complicated. Doug -- This .signature sanitized for your protection