From owner-freebsd-bugs@FreeBSD.ORG  Fri Mar 28 15:00:01 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 44B1910656C0
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 28 Mar 2008 15:00:01 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 18CE78FC17
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 28 Mar 2008 15:00:01 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m2SF00wV072051
	for <freebsd-bugs@freefall.freebsd.org>; Fri, 28 Mar 2008 15:00:00 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m2SF00Ip072050;
	Fri, 28 Mar 2008 15:00:00 GMT (envelope-from gnats)
Resent-Date: Fri, 28 Mar 2008 15:00:00 GMT
Resent-Message-Id: <200803281500.m2SF00Ip072050@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Christian Kandeler <christian.kandeler@hob.de>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 50F86106566C
	for <freebsd-gnats-submit@FreeBSD.org>;
	Fri, 28 Mar 2008 14:59:45 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 39F498FC23
	for <freebsd-gnats-submit@FreeBSD.org>;
	Fri, 28 Mar 2008 14:59:45 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m2SExQqq018979
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 28 Mar 2008 14:59:26 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m2SExQ0k018978;
	Fri, 28 Mar 2008 14:59:26 GMT (envelope-from nobody)
Message-Id: <200803281459.m2SExQ0k018978@www.freebsd.org>
Date: Fri, 28 Mar 2008 14:59:26 GMT
From: Christian Kandeler <christian.kandeler@hob.de>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: misc/122195: Alignment problems in if_ed
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Mar 2008 15:00:01 -0000


>Number:         122195
>Category:       misc
>Synopsis:       Alignment problems in if_ed
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar 28 15:00:00 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Christian Kandeler
>Release:        7.0
>Organization:
HOB
>Environment:
>Description:
Function ed_pio_write_mbufs() in sys/dev/ed/if_ed.c has at least two alignment problems:
    1) The savebyte array is cast to an unsigned short pointer and then dereferenced, but since it is a character array, it may not be suitably aligned.
    2) The call to ed_asic_outsw() assumes that the data pointer can be dereferenced as an unsigned short, but I don't think there is any guarantee that it fulfills the alignment requirements.
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted: