From owner-freebsd-chat@FreeBSD.ORG Fri Dec 14 10:18:02 2007 Return-Path: Delivered-To: freebsd-chat@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 94F4016A41A; Fri, 14 Dec 2007 10:18:02 +0000 (UTC) (envelope-from olli@lurza.secnetix.de) Received: from lurza.secnetix.de (lurza.secnetix.de [IPv6:2001:1b20:1:3::1]) by mx1.freebsd.org (Postfix) with ESMTP id 1466613C44B; Fri, 14 Dec 2007 10:18:01 +0000 (UTC) (envelope-from olli@lurza.secnetix.de) Received: from lurza.secnetix.de (localhost [127.0.0.1]) by lurza.secnetix.de (8.14.1/8.14.1) with ESMTP id lBEAHjdZ051972; Fri, 14 Dec 2007 11:17:50 +0100 (CET) (envelope-from oliver.fromme@secnetix.de) Received: (from olli@localhost) by lurza.secnetix.de (8.14.1/8.14.1/Submit) id lBEAHi77051971; Fri, 14 Dec 2007 11:17:44 +0100 (CET) (envelope-from olli) Date: Fri, 14 Dec 2007 11:17:44 +0100 (CET) Message-Id: <200712141017.lBEAHi77051971@lurza.secnetix.de> From: Oliver Fromme To: freebsd-chat@FreeBSD.ORG, das@FreeBSD.ORG, julian@elischer.org In-Reply-To: <20071213234413.GA28240@VARK.MIT.EDU> X-Newsgroups: list.freebsd-chat User-Agent: tin/1.8.3-20070201 ("Scotasay") (UNIX) (FreeBSD/6.2-STABLE-20070808 (i386)) MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.1.2 (lurza.secnetix.de [127.0.0.1]); Fri, 14 Dec 2007 11:17:50 +0100 (CET) Cc: Subject: Re: cvs commit: src/sys/conf files src/sys/netinet tcp_ofld.c ?tcp_ofld.h tcp_var.h toedev.h src/sys/sys socket.h X-BeenThere: freebsd-chat@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: freebsd-chat@FreeBSD.ORG, das@FreeBSD.ORG, julian@elischer.org List-Id: Non technical items related to the community List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2007 10:18:02 -0000 David Schultz wrote: > Julian Elischer wrote: > > > > sys/netinet tcp_ofld.c tcp_ofld.h toedev.h > > > > Log: > > > > Add driver independent interface to offload active established TCP > > > > connections > > > > > > > > Reviewed by: silby > > > > > > > > Revision Changes Path > > > > 1.1256 +1 -0 src/sys/conf/files > > > > 1.1 +126 -0 src/sys/netinet/tcp_ofld.c (new) > > > > 1.1 +198 -0 src/sys/netinet/tcp_ofld.h (new) > > > > I think I'd have just gone for > > tcp_offload.c > > it's not the longest filename in the system. I agree with Julian here. This isn't DOS where we need to fit filenames in 8.3 characters. There's no reason to abbreviate that way. > I don't think > src/contrib/bind9/doc/draft/draft-ietf-dnsext-signed-nonexistence-requirements-01.txt > should really count because it's a vendor source, though. > We do, however, have > src/lib/libarchive/archive_read_support_compression_compress.c Just out of curiosity I made a small survery on the src tree. First in src/sys only (this is a RELENG_6 machine): $ cd /sys $ find * | awk -F/ '{print length($NF)}' | sucs -k2 92 2 316 3 251 4 508 5 503 6 587 7 1506 8 816 9 919 10 678 11 629 12 499 13 348 14 224 15 153 16 85 17 58 18 48 19 25 20 24 21 6 22 11 23 5 24 5 25 3 26 1 29 1 33 As you can see, the maximum of the count graph of filenames' lengths is at 8 characters. The median is 9, the average is 9.4 chars. 18% of the filenames are 13 characters or longer, therefore "tcp_offload.[ch]" wouldn't be that unusual at all. When you look at C source files only ("find * -name \*.c"), then the average even reaches 10.6. By the way, "sucs" is an alias: sort | uniq -c | sort -n (I use that often.) It's not much different when you look at /usr/src which includes the 3d party contrib stuff (I grouped some of the lines for brevity): $ cd /usr/src $ find * | awk -F/ '{print length($NF)}' | sucs -k2 14 1 437 2 1173 3 1603 4 2489 5 3228 6 3442 7 6647 8 4173 9 3951 10 3370 11 2855 12 1921 13 1565 14 1062 15 841 16 752 17 430 18 446 19 707 20 - 24 250 25 - 29 95 30 - 34 51 35 - 39 12 40 - 44 11 45 - 49 1 50 1 51 1 52 1 57 The maximum is at 8 again, the median is 9 again, and the average is 9.7 (just slightly longer than in /sys). When only looking at C source files, the average is 10.2. Best regards Oliver "Mr. Statistics" -- Oliver Fromme, secnetix GmbH & Co. KG, Marktplatz 29, 85567 Grafing b. M. Handelsregister: Registergericht Muenchen, HRA 74606, Geschäftsfuehrung: secnetix Verwaltungsgesellsch. mbH, Handelsregister: Registergericht Mün- chen, HRB 125758, Geschäftsführer: Maik Bachmann, Olaf Erb, Ralf Gebhart FreeBSD-Dienstleistungen, -Produkte und mehr: http://www.secnetix.de/bsd "Unix gives you just enough rope to hang yourself -- and then a couple of more feet, just to be sure." -- Eric Allman