From owner-svn-src-all@freebsd.org Tue Aug 23 20:53:13 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 64F67BC4522; Tue, 23 Aug 2016 20:53:13 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-x241.google.com (mail-pa0-x241.google.com [IPv6:2607:f8b0:400e:c03::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3260A1724; Tue, 23 Aug 2016 20:53:13 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pa0-x241.google.com with SMTP id vy10so10450120pac.0; Tue, 23 Aug 2016 13:53:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=SXHphuC3ghjZb3YBC6g2Syzr8mi+lmINdSkks6JCAoM=; b=uS1U7HsyUOoINtzF7wsN8M3Nf63HYpHpEvfOt1E1J2zfSM5N6k4aCXqmFK/WR0jvgD cz5VWBkGXm9GZhbsQ8yFZqaUaGpW+sSvQYOeRRa7LeLR9o8fBnIV5aW8Hqs82WYrq876 Tx+luHMkoXRAKwJkWCSEMrE9hrmKZ7ved/WeRqX3+fWYq+Jiu9ieo+gFjZTqNWabQCku fRi4aq/Vy/d/a6/MLk+LlezPRN0O8GkNrqW1pRmLAnPEXP+htDJhcLYPBgSQlQ/LIf+f alWDHLs6166vk24zY/LgTEFKnZ9hwdvZAfLlRCrDyEvBLf5IsYvfqEjBjGWIXjxfiDVi +mIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=SXHphuC3ghjZb3YBC6g2Syzr8mi+lmINdSkks6JCAoM=; b=axt7T5A6XdCn6RXPrDw9y9jt2507ozejSSo81oxISV2di3DNz4YHvPmO+2le+Uynvk ud4vAfrw5MD3jxb2nKaSjvpSQkyG4FBTeg4IqL6jtVF830l/gJnoop+ShzEMX8mT1yzi 1k+NeKMfCvdswgEoe2e3n/ArDuHcjB6AO/Tng8FJvKcAUzJ7LfB8QMqgpoKh7LSrR0KC 774YJPW93hzte2jRZxkAdkcFiArk8jtpPcFsexdirEuzjorXqw02FM7Y+cIzyaaji+yD erRrUaY2mCDwNPmcgBPbykpAPjH6J9PihhptGnW2e9sXlRfhLTyNNM6wnGpqbaWyyPmz lwGg== X-Gm-Message-State: AEkoout6p2McuZ52T+9vaLPO73JaOsJReK5SztF/jxAbDdJ9FlIl5f9njXGpgvV9zL3sIg== X-Received: by 10.66.216.130 with SMTP id oq2mr56688604pac.89.1471985592535; Tue, 23 Aug 2016 13:53:12 -0700 (PDT) Received: from [192.168.20.17] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id 72sm7877840pfs.51.2016.08.23.13.53.11 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 23 Aug 2016 13:53:11 -0700 (PDT) Subject: Re: svn commit: r304703 - head/include/xlocale Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_1841782D-4B2F-4847-A4B0-18B39710379A"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <201608232033.u7NKXuZ9054093@repo.freebsd.org> Date: Tue, 23 Aug 2016 13:53:10 -0700 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: References: <201608232033.u7NKXuZ9054093@repo.freebsd.org> To: "Andrey A. Chernov" X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Aug 2016 20:53:13 -0000 --Apple-Mail=_1841782D-4B2F-4847-A4B0-18B39710379A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Aug 23, 2016, at 13:33, Andrey A. Chernov wrote: >=20 > Author: ache > Date: Tue Aug 23 20:33:56 2016 > New Revision: 304703 > URL: https://svnweb.freebsd.org/changeset/base/304703 >=20 > Log: > LC_*_MASK bit shifting order was partially broken from the initial = commit > time at year 2012. Only LC_COLLATE_MASK and LC_CTYPE_MASK are in the > right order. >=20 > The order here should match XLC_* from "xlocale_private.h" which, in = turn, > match LC_* publicly visible order from which determines = how > locale components are stored in the structure. > LC_*_MASK -> XLC_* translation done as "ffs(mask) - 1" in the = querylocale() > and equivalent shift loop in the newlocale(), so mapped to some wrong > components (excluding two mentioned above). >=20 > Formally the fix is ABI breakage, but old code using those masks > never works properly in any case. > Only newlocale() and querylocale() are affected. >=20 > MFC after: 7 days >=20 > Modified: > head/include/xlocale/_locale.h Should __FreeBSD_version be bumped? Thanks, -Ngie --Apple-Mail=_1841782D-4B2F-4847-A4B0-18B39710379A Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJXvLe3AAoJEPWDqSZpMIYVgl0QAJRNqTv9K7PbWcQh/m/4s+TV nbpgZqwkJ9uweecBWuGXth89FA+WEDLm2aluSmiADpTxhEp5hZJ+uAaIded57pXz 96Npmsh4+EzKt8FUyI3BlVPhRRP5A+JsJBkce2JA+4cE9d1iiRWP69qWRxBjJVEz R1/Cy/PlUGxVZ0v+EQ71reeZ8Tk0ko+yafpVjwPlOqBNzgXarHZ5PIpMXF/Q5O19 BPRifcU7w4kZ7avdjrwunph3yp7jad/lUbdjwqgIZcYe2bkciwccgn2azzycFxy/ GEeqgyAQXkGfbBAgpwK9msOgxQvqW8zfYnpEQMhO6MXQywqaIwspELcsaLMzm8/B 2KLgWzk0mFbu6WeS9NbgdMbrWrEAqi41S83HvAgObDeJXjT8XiuoG1t8TdJku66I HAQtJ5b1hGq6RG3ubei/Ya0uA0pevKtSnzKVC9lC9yX5m17cq27jkA9CuooDQ/l/ bnkhuRE08kNpkLkYOXOvwu91Yn5dyUmaQtTWOKlttbG3iPsPT0QNLmX491KsY/4I 6cZCNCgFPYFuZQ1GobQ8m6/omfUE2i6QBCCilcoQ7xUDdwLHoZI+aWhtfbryBl8p oDNOxOV0E/YqCOIE+6ujejEDwF95/M/1x04vn0qEOjWKiI4Ve1uRWuVN5Wo1Hj/w 2ol2OgtGcSBLw3uvvSWb =DfR5 -----END PGP SIGNATURE----- --Apple-Mail=_1841782D-4B2F-4847-A4B0-18B39710379A--