From owner-freebsd-arch@FreeBSD.ORG  Sun Jun 22 01:59:27 2003
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6376837B401; Sun, 22 Jun 2003 01:59:27 -0700 (PDT)
Received: from HAL9000.homeunix.com (ip114.bella-vista.sfo.interquest.net
	[66.199.86.114])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id BEDE143F85; Sun, 22 Jun 2003 01:59:26 -0700 (PDT)
	(envelope-from dschultz@OCF.Berkeley.EDU)
Received: from HAL9000.homeunix.com (localhost [127.0.0.1])
	by HAL9000.homeunix.com (8.12.9/8.12.9) with ESMTP id h5M8xNJa062114;
	Sun, 22 Jun 2003 01:59:24 -0700 (PDT)
	(envelope-from dschultz@OCF.Berkeley.EDU)
Received: (from das@localhost)
	by HAL9000.homeunix.com (8.12.9/8.12.9/Submit) id h5M8xNOF062113;
	Sun, 22 Jun 2003 01:59:23 -0700 (PDT)
	(envelope-from dschultz@OCF.Berkeley.EDU)
Date: Sun, 22 Jun 2003 01:59:23 -0700
From: David Schultz <dschultz@OCF.Berkeley.EDU>
To: Ruslan Ermilov <ru@FreeBSD.org>
Message-ID: <20030622085923.GA62034@HAL9000.homeunix.com>
Mail-Followup-To: Ruslan Ermilov <ru@FreeBSD.org>,
	Bruce Evans <bde@zeta.org.au>, arch@FreeBSD.org
References: <20030622005124.GA59673@HAL9000.homeunix.com>
	<20030622035258.GB60460@HAL9000.homeunix.com>
	<20030622180851.K55800@gamplex.bde.org> <20030622083714.GD99674@sunbay.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030622083714.GD99674@sunbay.com>
cc: arch@FreeBSD.org
Subject: Re: Per-source CFLAGS
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussion related to FreeBSD architecture
	<freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Jun 2003 08:59:27 -0000

On Sun, Jun 22, 2003, Ruslan Ermilov wrote:
> I still have some concerns with the proposed implementation.
> All already existing per-file knobs override the global knob,
> and I think that maybe the per-source CFLAGS should behave
> the same?  Doing it this way is more flexible; you're free
> to augment the global CFLAGS by saying
> 
> CFLAGS_foo.c=	${CFLAGS} -DFOO

Overriding the global settings is kinda the point, but FWIW, your
proposal is indeed more flexible.  But can you think of a way to
implement it that doesn't involve generating a CFLAGS_foo.c
variable for every file?