From owner-freebsd-embedded@FreeBSD.ORG  Wed Dec 28 12:50:01 2011
Return-Path: <owner-freebsd-embedded@FreeBSD.ORG>
Delivered-To: freebsd-embedded@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0B8F61065670
	for <freebsd-embedded@freebsd.org>;
	Wed, 28 Dec 2011 12:50:01 +0000 (UTC)
	(envelope-from adrian.chadd@gmail.com)
Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com
	[209.85.212.54])
	by mx1.freebsd.org (Postfix) with ESMTP id A5C6D8FC15
	for <freebsd-embedded@freebsd.org>;
	Wed, 28 Dec 2011 12:50:00 +0000 (UTC)
Received: by vbbfr13 with SMTP id fr13so17140042vbb.13
	for <freebsd-embedded@freebsd.org>;
	Wed, 28 Dec 2011 04:50:00 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	bh=G2WS4YPMbRONKnW8gM+9ZokDrl+lq5OpCJzFY60N1lk=;
	b=Acikh0fnax6NbVvbOrJO1bktobHOEU+wdDclHvrYNw+VHYOAo3diOzKJrVIG9oa62I
	WGFUgH7frSXjIfTayy/bQT/iY2ziulQMwQ9IQD8QrB8ADJDY9v1xQFN9CaFzxJf52HJP
	fLAWjZun1eeaxzLJI89W4bMKRNKRg+cOcv9y4=
MIME-Version: 1.0
Received: by 10.52.33.99 with SMTP id q3mr15138130vdi.100.1325076600136; Wed,
	28 Dec 2011 04:50:00 -0800 (PST)
Sender: adrian.chadd@gmail.com
Received: by 10.52.36.5 with HTTP; Wed, 28 Dec 2011 04:50:00 -0800 (PST)
In-Reply-To: <12538AED-175C-4B1E-BF05-6FD05D14CE70@lassitu.de>
References: <CAJ-Vmon8+OXQ4g752zZEB-O0BR0sFWO0QUvw--xp2jsBDkx6tQ@mail.gmail.com>
	<0F6CC18F-6973-42A2-AC03-F01BF59458AE@lassitu.de>
	<CAJ-Vmo=Y8pp4iFnw+1hcPae6QXFboz=a7puwgC1kVSZ3JwMgPQ@mail.gmail.com>
	<1100F70E-9DA9-4163-AC9A-423ECE5AA9A3@lassitu.de>
	<CAJ-VmonrnJ7cC6u2LsL9AGusz_+kSwY62Rr1__sg5U_NynJ1SQ@mail.gmail.com>
	<CAJ-Vmo=WSN1oLM=B2HqSHrWyOaOD9BSwwu8=1Wys0CLRJ_N-TA@mail.gmail.com>
	<C637C171-A1A2-4296-84FA-6DE97137DC42@lassitu.de>
	<CAJ-Vmon2boy7OCh_4O0MeCi0yCdZu0OYb5dxHCEK=-+46zBGtg@mail.gmail.com>
	<CAJ-Vmoku5eLEYi5_DXVxK=0=4Ewn2aGepv3YUw4ApuVh_7y2+w@mail.gmail.com>
	<CAJ-VmonvpnaS1rAO+sDRh1E5WfsrZTYE297Kc96prhfKjrM89Q@mail.gmail.com>
	<CAJ-VmokQxQs2DUKL=ONyxnnS7Q28ytmwZJ_thqvc4SvMkmS=cQ@mail.gmail.com>
	<18CABB46-9B9A-41CB-8742-6723C5FF4D67@lassitu.de>
	<C0BF20FD-E30F-4E9C-A0FE-500BE4807B99@bsdimp.com>
	<CAJ-VmokgiQCEG4et3X=3o_MuCMkO9MqkKqa-fjdpEqQNucn=Lw@mail.gmail.com>
	<2CBD8651-E132-49DC-A082-37A8F5C626EA@bsdimp.com>
	<AFE755D6-E462-40B4-A97B-9261303B3A4F@lassitu.de>
	<45529EC2-73BE-4F69-A9BE-E22D9FEAADD7@lassitu.de>
	<CAJ-VmonmMASxJZBAd2doX4eV6s5TF-3kCB0pLSMrWM8r0UsCmg@mail.gmail.com>
	<FC8A0B08-5292-44CC-AEC0-08BF170FCEA4@lassitu.de>
	<267FB3D6-830E-4A2F-8C1C-A96873EDCD31@lassitu.de>
	<EC4D4397-FA60-4CB1-8635-48988215E19A@lassitu.de>
	<CAJ-VmomZeHEyue4eaNGm+w67uDBsOH_2bqocXjBGxyxHXStZ_A@mail.gmail.com>
	<12538AED-175C-4B1E-BF05-6FD05D14CE70@lassitu.de>
Date: Wed, 28 Dec 2011 04:50:00 -0800
X-Google-Sender-Auth: z-ulXVTTaKdDfEyxqXeATASmUrs
Message-ID: <CAJ-Vmonu_HyhEnS=3aj7X41-LPWcihPA6Wa6jgV3cn7im2N3Kg@mail.gmail.com>
From: Adrian Chadd <adrian@freebsd.org>
To: Stefan Bethke <stb@lassitu.de>
Content-Type: text/plain; charset=ISO-8859-1
Cc: "freebsd-embedded@freebsd.org" <freebsd-embedded@freebsd.org>
Subject: Re: Updated switch/glue patch?
X-BeenThere: freebsd-embedded@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Dedicated and Embedded Systems <freebsd-embedded.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-embedded>, 
	<mailto:freebsd-embedded-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-embedded>
List-Post: <mailto:freebsd-embedded@freebsd.org>
List-Help: <mailto:freebsd-embedded-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-embedded>, 
	<mailto:freebsd-embedded-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Dec 2011 12:50:01 -0000

Hi,

Ok, can you then please send me an updated diff which:

* renames *_lockheld() to *_locked(), just for consistency with the kernel;
* rename smi_mtx back to sc_mtx, just for consistency;
* add _LOCK, _UNLOCK, _LOCK_ASSERT, _UNLOCK_ASSERT macros;
* use those to enforce correct locking. :)

Let's do that. We'll then worry about the callout mutex use afterwards.



Adrian