From owner-p4-projects@FreeBSD.ORG  Sun May  9 00:25:26 2010
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id E2BED1065677; Sun,  9 May 2010 00:25:25 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 8EEE31065670
	for <perforce@FreeBSD.org>; Sun,  9 May 2010 00:25:25 +0000 (UTC)
	(envelope-from gcooper@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id 74B398FC19
	for <perforce@FreeBSD.org>; Sun,  9 May 2010 00:25:25 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o490PPln086485
	for <perforce@FreeBSD.org>; Sun, 9 May 2010 00:25:25 GMT
	(envelope-from gcooper@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o490PP7S086483
	for perforce@freebsd.org; Sun, 9 May 2010 00:25:25 GMT
	(envelope-from gcooper@FreeBSD.org)
Date: Sun, 9 May 2010 00:25:25 GMT
Message-Id: <201005090025.o490PP7S086483@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	gcooper@FreeBSD.org using -f
From: Garrett Cooper <gcooper@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Precedence: bulk
Cc: 
Subject: PERFORCE change 177985 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 09 May 2010 00:25:26 -0000

http://p4web.freebsd.org/@@177985?ac=10

Change 177985 by gcooper@gcooper-bayonetta on 2010/05/09 00:24:45

	- Convert trailing hard tabs in ADD_FILE to spaces for readability in
	  diffs.
	- Remove an unused constant.

Affected files ...

.. //depot/projects/soc2007/gcooper-pkg_install-enhancements-simplified/usr.sbin/pkg_install/create/perform.c#6 edit

Differences ...

==== //depot/projects/soc2007/gcooper-pkg_install-enhancements-simplified/usr.sbin/pkg_install/create/perform.c#6 (text+ko) ====

@@ -343,43 +343,39 @@
     return TRUE;	/* Success */
 }
 
-#define COMPRESS_ARCHIVE_FLAGS	(ARCHIVE_EXTRACT_OWNER |ARCHIVE_EXTRACT_PERM| \
-				 ARCHIVE_EXTRACT_TIME  |ARCHIVE_EXTRACT_ACL | \
-				 ARCHIVE_EXTRACT_FFLAGS|ARCHIVE_EXTRACT_XATTR)
-
 static void
 make_dist(const char *homedir, const char *pkg, const char *suff, Package *plist)
 {
 
-#define ADD_FILE(src_file, dest_file)					       \
-	if (error == NULL) {						       \
-		if ((archive_entry_fd = open(src_file,			       \
-		    archive_entry_fd)) == -1 ||				       \
-		    fstat(archive_entry_fd, sb) == -1) {		       \
-			error = strerror(errno);			       \
-		} else if ((archive_entry_map_addr = mmap(NULL,		       \
-		    PROT_READ, sb->st_size, MAP_SHARED,			       \
-		    archive_entry_fd, 0)) == NULL) {			       \
-			error = strerror(errno);			       \
-		} else {						       \
-			if ((entry = archive_entry_new()) == NULL)	       \
-				error = archive_error_string(archive);	       \
-			else {						       \
-				archive_entry_copy_stat(entry, sb);	       \
-				if (archive_write_header(archive,	       \
-				    entry) != ARCHIVE_OK)		       \
-					error = archive_error_string(archive); \
-				else if (archive_write_data(archive,	       \
-				    archive_entry_map_addr,		       \
-				    sb->st_size) != ARCHIVE_OK)		       \
-					error = archive_error_string(archive); \
-				(void) munmap(archive_entry_map_addr,	       \
-				    sb->st_size);			       \
-				archive_entry_free(entry);		       \
-			}						       \
-		}							       \
-		if (0 <= archive_entry_fd)				       \
-			close(archive_entry_fd);			       \
+#define ADD_FILE(src_file, dest_file)                                         \
+	if (error == NULL) {                                                  \
+		if ((archive_entry_fd = open(src_file,                        \
+		    archive_entry_fd)) == -1 ||                               \
+		    fstat(archive_entry_fd, sb) == -1) {                      \
+			error = strerror(errno);                              \
+		} else if ((archive_entry_map_addr = mmap(NULL,               \
+		    PROT_READ, sb->st_size, MAP_SHARED,                       \
+		    archive_entry_fd, 0)) == NULL) {                          \
+			error = strerror(errno);                              \
+		} else {                                                      \
+			if ((entry = archive_entry_new()) == NULL)            \
+				error = archive_error_string(archive);        \
+			else {                                                \
+				archive_entry_copy_stat(entry, sb);           \
+				if (archive_write_header(archive,             \
+				    entry) != ARCHIVE_OK)                     \
+					error = archive_error_string(archive);\
+				else if (archive_write_data(archive,          \
+				    archive_entry_map_addr,                   \
+				    sb->st_size) != ARCHIVE_OK)               \
+					error = archive_error_string(archive);\
+				(void) munmap(archive_entry_map_addr,         \
+				    sb->st_size);                             \
+				archive_entry_free(entry);                    \
+			}                                                     \
+		}                                                             \
+		if (0 <= archive_entry_fd)                                    \
+			close(archive_entry_fd);                              \
 	}
 
 #if NOTYET