From owner-svn-src-head@freebsd.org Thu Dec 7 00:38:08 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 394A2E92121; Thu, 7 Dec 2017 00:38:08 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0238F6ABF3; Thu, 7 Dec 2017 00:38:08 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 21A9A16471; Thu, 7 Dec 2017 00:38:07 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 54B202BE5; Thu, 7 Dec 2017 00:38:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id HF7QetJXAZ3h; Thu, 7 Dec 2017 00:38:03 +0000 (UTC) Subject: Re: svn commit: r326169 - in head: . contrib/ofed lib/libc/locale share/mk sys/amd64/amd64 sys/amd64/conf sys/conf sys/contrib/rdma/krping sys/dev/cxgbe sys/dev/cxgbe/common sys/dev/cxgbe/iw_cxgbe sys/... DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com EE2CA2BE0 To: Hans Petter Selasky , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201711241450.vAOEoSFW056744@repo.freebsd.org> <0fec20d5-cb8f-4937-5dd0-54b8b7461772@selasky.org> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: Date: Wed, 6 Dec 2017 16:38:06 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <0fec20d5-cb8f-4937-5dd0-54b8b7461772@selasky.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1QWGnaSJPHJg9gnOFoXLiu13XkKQFuGCG" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 00:38:08 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1QWGnaSJPHJg9gnOFoXLiu13XkKQFuGCG Content-Type: multipart/mixed; boundary="cVpSAnSmk16r7nnuBOpGxLfJkfCoorewr"; protected-headers="v1" From: Bryan Drewery To: Hans Petter Selasky , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: Subject: Re: svn commit: r326169 - in head: . contrib/ofed lib/libc/locale share/mk sys/amd64/amd64 sys/amd64/conf sys/conf sys/contrib/rdma/krping sys/dev/cxgbe sys/dev/cxgbe/common sys/dev/cxgbe/iw_cxgbe sys/... References: <201711241450.vAOEoSFW056744@repo.freebsd.org> <0fec20d5-cb8f-4937-5dd0-54b8b7461772@selasky.org> In-Reply-To: <0fec20d5-cb8f-4937-5dd0-54b8b7461772@selasky.org> --cVpSAnSmk16r7nnuBOpGxLfJkfCoorewr Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 12/6/2017 4:28 PM, Hans Petter Selasky wrote: > On 12/07/17 01:10, Bryan Drewery wrote: >> I'm a bit speechless.=C2=A0 Why??=C2=A0 The old version was 90% fine a= nd I sent >> you advice on how to make it work with the new layout. >=20 > Hi, >=20 > I tried to listen to your advice, splitting up the Makefiles, not > listing every dependency. Further how the OFED libraries are linked has= > changed. Two iterations for building the OFED libraries is not enough, > like before. We really need four iterations. >=20 > I don't see how the current approach is "wrong". Can you explain a bit > more? 1. SUBDIR=3D../../somewhere else is inherently wrong. 2. Building a library from a directory named '2' is wrong. 3. Not just using proper SUBDIR_DEPEND and making all these subdirs is not needed and complicates things MORE by splitting them all up. 4. Building a library from a directory where its real bsd.lib.mk is not at is wrong. 5. Depending on an include directory in the Makefile.inc1 library dependencies is simply not needed - I told you that. 6. Using these /0 /1 /2 /3 directories actually hurts the 'make libraries' parallelism/dependency graph. It ends up building /1 rather than building libibcm and libibumad directly in its graph. It creates an indirection which adds more unneeded submake recursion. The whole thing needlessly obfuscates these libraries. It's fine, I'm going to rewrite it all now. --=20 Regards, Bryan Drewery --cVpSAnSmk16r7nnuBOpGxLfJkfCoorewr-- --1QWGnaSJPHJg9gnOFoXLiu13XkKQFuGCG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJaKI1vAAoJEDXXcbtuRpfPnoEH/1Axa1BVXU1po6uj6WuTFJ/H FYPxpVkUteqzhg8j7784/bRMbu9QseB8YkF0adnZ8704+VwFQ328LXaP7BrT8TGe BOvyTRaPI2roWgspGLXwqWPBOkRwWb0PFba8DKq7agmSpj5GeJpIUy8qswurEWgT tRxZ0kF36oHsB53PQWQO7R9ExIQ4iH2jbUvvIkFTWUgNcqxfQkF71XJxliM/9aIF c91ybwe6uq05tinmuHdt3F0lsSPJN5Nm/T6NoZbSeMDaBWMRr7Ra5GD/apN8b+l8 X3qpb5j+2ZUXcrOztZesqdzW0gZhPWIT77XXdbawKn3mzzLsYDf0WWrUw06+ybE= =cFoI -----END PGP SIGNATURE----- --1QWGnaSJPHJg9gnOFoXLiu13XkKQFuGCG--