From owner-freebsd-current@FreeBSD.ORG Tue Apr 26 22:49:06 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 407EA16A4CE for ; Tue, 26 Apr 2005 22:49:06 +0000 (GMT) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id B4A7143D41 for ; Tue, 26 Apr 2005 22:49:05 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (localhost [127.0.0.1]) by ns1.xcllnt.net (8.13.3/8.13.3) with ESMTP id j3QMn3BF037092; Tue, 26 Apr 2005 15:49:03 -0700 (PDT) (envelope-from marcel@ns1.xcllnt.net) Received: (from marcel@localhost) by ns1.xcllnt.net (8.13.3/8.13.3/Submit) id j3QMn3Bw037091; Tue, 26 Apr 2005 15:49:03 -0700 (PDT) (envelope-from marcel) Date: Tue, 26 Apr 2005 15:49:03 -0700 From: Marcel Moolenaar To: Jose M Rodriguez Message-ID: <20050426224903.GA37052@ns1.xcllnt.net> References: <200504261143.55195.josemi@redesjm.local> <200504270005.56024.josemi@redesjm.local> <20050426221612.GC8621@ns1.xcllnt.net> <200504270026.41851.josemi@redesjm.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200504270026.41851.josemi@redesjm.local> User-Agent: Mutt/1.4.2.1i cc: freebsd-current@freebsd.org Subject: Re: rigth crc32 implementation X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2005 22:49:06 -0000 On Wed, Apr 27, 2005 at 12:26:40AM +0200, Jose M Rodriguez wrote: > El Mi?rcoles, 27 de Abril de 2005 00:16, Marcel Moolenaar escribi?: > > On Wed, Apr 27, 2005 at 12:05:54AM +0200, Jose M Rodriguez wrote: > > > > I'll add crc32_raw() and rewrite the existing crc32() to use it. > > > > Give me a day or so. I'd like to have at least crc32() inlined. > > > > Maybe crc32_raw() as well. Both are trivial functions and there > > > > may be an advantage to have them inlined. If only to remove the > > > > performance argument against unification. > > > > > > NOPE, I still have things in my TODO for a month or so. > > > > Ok, we officially have a disconnect now. What do you mean with having > > things in your TODO list for a month and why does that result in you > > disagreeing with my proposal and the change I'll be making to FreeBSD > > on your behalf? > > > > Thanks, > > Sorry, > > I only point you have the time you need to make this. Ok, I see. Thanks for your concern. The change is trivial and since the issue has come up, it's best to deal with it right away. It'll be forgotten otherwise and you have to raise the issue again when you're good and ready for it. Also, the sooner it's in -CURRENT, the better the chances someone picks takes this a step further and works on the unification of all crc32 implementations. There is awareness now and I don't expect it to stick in peoples mind for longer than a couple of days. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net