From owner-svn-src-all@freebsd.org Wed Jun 26 20:45:46 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 82CFD15D1DB2; Wed, 26 Jun 2019 20:45:46 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DCC1A87556; Wed, 26 Jun 2019 20:45:45 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x5QKjivm056236; Wed, 26 Jun 2019 13:45:44 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x5QKji74056235; Wed, 26 Jun 2019 13:45:44 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201906262045.x5QKji74056235@gndrsh.dnsmgr.net> Subject: Re: svn commit: r349435 - stable/11/usr.sbin/bhyve In-Reply-To: <201906261742.x5QHglDw089564@repo.freebsd.org> To: Mark Johnston Date: Wed, 26 Jun 2019 13:45:44 -0700 (PDT) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: DCC1A87556 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.93 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.93)[-0.935,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jun 2019 20:45:46 -0000 > Author: markj > Date: Wed Jun 26 17:42:47 2019 > New Revision: 349435 > URL: https://svnweb.freebsd.org/changeset/base/349435 > > Log: > MFC r349196: > Make zlib encoding messages idempotent. Is this headed for 11.3RC3? IIRC this fixes a significant number of vnc client related issues? > PR: 238333 > > Modified: > stable/11/usr.sbin/bhyve/rfb.c > Directory Properties: > stable/11/ (props changed) > > Modified: stable/11/usr.sbin/bhyve/rfb.c > ============================================================================== > --- stable/11/usr.sbin/bhyve/rfb.c Wed Jun 26 17:41:38 2019 (r349434) > +++ stable/11/usr.sbin/bhyve/rfb.c Wed Jun 26 17:42:47 2019 (r349435) > @@ -270,8 +270,10 @@ rfb_recv_set_encodings_msg(struct rfb_softc *rc, int c > rc->enc_raw_ok = true; > break; > case RFB_ENCODING_ZLIB: > - rc->enc_zlib_ok = true; > - deflateInit(&rc->zstream, Z_BEST_SPEED); > + if (!rc->enc_zlib_ok) { > + deflateInit(&rc->zstream, Z_BEST_SPEED); > + rc->enc_zlib_ok = true; > + } > break; > case RFB_ENCODING_RESIZE: > rc->enc_resize_ok = true; > > -- Rod Grimes rgrimes@freebsd.org