From owner-cvs-all@FreeBSD.ORG Wed Oct 27 08:25:02 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1183616A4CE; Wed, 27 Oct 2004 08:25:02 +0000 (GMT) Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id BA49F43D41; Wed, 27 Oct 2004 08:25:01 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.13.1/8.13.1) with ESMTP id i9R8OqGc019841; Wed, 27 Oct 2004 01:24:56 -0700 (PDT) (envelope-from truckman@FreeBSD.org) Message-Id: <200410270824.i9R8OqGc019841@gw.catspoiler.org> Date: Wed, 27 Oct 2004 01:24:52 -0700 (PDT) From: Don Lewis To: phk@FreeBSD.org In-Reply-To: <200410270805.i9R853Wb066467@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_subr.c src/sys/sys buf.h bufobj.h vnode.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Oct 2004 08:25:02 -0000 On 27 Oct, Poul-Henning Kamp wrote: > phk 2004-10-27 08:05:03 UTC > > FreeBSD src repository > > Modified files: > sys/kern vfs_subr.c > sys/sys buf.h bufobj.h vnode.h > Log: > Move the syncer linkage from vnode to bufobj. > > This is not quite a perfect separation: the syncer still think it knows > that everything is a vnode. This change strikes me as wrong. The syncer has to handle things like inode timestamps (utimes(2)) and fifos, which I wouldn't expect to have bufobjs.