From owner-freebsd-current@FreeBSD.ORG  Mon Aug  1 16:21:37 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 472BC1065677;
	Mon,  1 Aug 2011 16:21:37 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 20EB48FC18;
	Mon,  1 Aug 2011 16:21:37 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id 5F0B546B03;
	Mon,  1 Aug 2011 12:21:36 -0400 (EDT)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id 003B98A02C;
	Mon,  1 Aug 2011 12:21:35 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Andriy Gapon <avg@freebsd.org>
Date: Mon, 1 Aug 2011 12:17:30 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110617; KDE/4.5.5; amd64; ; )
References: <4E35732A.8060807@FreeBSD.org> <201108010847.52235.jhb@freebsd.org>
	<4E36B805.6070804@FreeBSD.org>
In-Reply-To: <4E36B805.6070804@FreeBSD.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201108011217.30206.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6
	(bigwig.baldwin.cx); Mon, 01 Aug 2011 12:21:36 -0400 (EDT)
Cc: freebsd-current@freebsd.org
Subject: Re: print_INTEL_info/print_INTEL_TLB
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Aug 2011 16:21:37 -0000

On Monday, August 01, 2011 10:28:21 am Andriy Gapon wrote:
> on 01/08/2011 15:47 John Baldwin said the following:
> > On Sunday, July 31, 2011 11:22:18 am Andriy Gapon wrote:
> >>
> >> Just an observation:
> >> - print_INTEL_info and print_INTEL_TLB are missing from amd64 identcpu.c
> >> - print_INTEL_TLB doesn't cover all the codes defined by Intel specs
> >> - not sure; perhaps print_INTEL_info should use deterministic cache 
> > parameters
> >> as provided by CPUID 0x4 for a more complete coverage...
> > 
> > It might be nice to create a sys/x86/x86/identcpu.c to merge the two which 
> > would help with some of this.
> 
> I agree with this suggestion regardless of the issue at hand.
> 
> > print_INTEL_TLB() hasn't been updated since it 
> > was added AFAIK which probably explains why it doesn't know about all of the 
> > codes.
> 
> Given the current state of this code - is it useful at all?
> Should we keep it in kernel provided that there are tools like cpuid, x86info, etc...?
> I would have no doubts if we gathered that information for some real use by kernel
> and then also printed it for user's convenience.  But if the code is there just
> for printing (and under bootverbose), then I am not really sure.

Yeah, I would be fine with just tossing it.

-- 
John Baldwin