From nobody Wed Apr 22 12:37:46 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g0zJp5B0mz6ZRTn for ; Wed, 22 Apr 2026 12:37:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g0zJp1LNvz3HSS for ; Wed, 22 Apr 2026 12:37:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776861466; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ql2pdj4VxL7K0P1kknCGLxN1pvzpHJR/tkuHMdxYsZs=; b=G299btI3Xd8kK0VmYChNpv27h8vL1UfWUaFqaDdu25coCluXmnlA9WdhF5dzUDHaPujGgG ffdoVHeFCctSigrq+UGw7yWjXUhMIlbsoxFbqXvDJ5qSmjRIhqm7tXyR7p0AO+VIrZWOBq M4NlQ0HQMA7oatVdu9tljCY49LVNKTaCaVsej0wckMwUdnGvNR6l5g2w7fEfb4fzzZLqPS +d4hNEZGBwnardjM8VRq0MbntcwV2Z/0YbFLOTTKVhNWmwbhSMhF+cRIcekIHd4mMnhDRK cYg4zCmFLnlqFyZsnQZmW8XztYjnu5iv2pfBcfB+3s9RV6s2EytyjMkmZ820EQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776861466; a=rsa-sha256; cv=none; b=Ni7erceJ7nq6KD3R1iLgXKrhAuR0q2GOSXMb8jqdiRYxqJ+P/W4u0RTe4Qd2nq+xhPNM9i NwENpAbi16dHnl+MHWjFFc7bsObk3gZqMW8XZHp1gsLCDxpvKQVt6iDMFoatF81zDOjqcx 2geZ3EdSv22PcDXawyDW1aogKM1lf2pnVgKZjqqra7+5qSDHEanLK1yoAMzAQ6D5LFgPJZ Tu66AvCQRVURPhxe345qFFdaVnlZAuWkIuLxorXSZVHEdq7QmNsdx7/1ypAz6+l6QdACu9 UUxrYPt6Wbv6Jb5lYyrD4Diz/ZU4BvgvhdFrVQxm0sTl3bAz/jS3KFUABeNN+g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776861466; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ql2pdj4VxL7K0P1kknCGLxN1pvzpHJR/tkuHMdxYsZs=; b=e/63DtPxAKkri1+IPzZx2PxCmGJZbYJTsj0JcugkKhx0aDg16tCH+aUilYaEsSYQYtJ8Uq yLy+LeS7fM8f8j/bSAltmMhdbcW4/b1QgcPZ8zubOHUIuDEn6chYt02cXNejh/PBzFXDwf NO8yJi5rTGQwBZvrkkhTDCDslkIq1AS1gYzpjMrAQh6D6aUNx8Zaqg8pOyeIE5wYzbB7II d2wQgPO6Qh3oHoVibyzMxX7LUzLohSPEqZ/O9oDEI7O9QA1KAHou4sfMSBDReK/vKmg9ig o7Fr8QgPTgVs0XyOnfwq7Qf9OZcG15/VrTsGfZ0aZaMKvNxsbf1fil7be7wIpw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g0zJp0v3WzVXd for ; Wed, 22 Apr 2026 12:37:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 19098 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 22 Apr 2026 12:37:46 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 8fe3978146d5 - stable/14 - linuxkpi: Fix an off-by-one error in the kfifo implementation List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 8fe3978146d5b694693bfabd4d72ba02f44eccab Auto-Submitted: auto-generated Date: Wed, 22 Apr 2026 12:37:46 +0000 Message-Id: <69e8c11a.19098.26e183c7@gitrepo.freebsd.org> The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=8fe3978146d5b694693bfabd4d72ba02f44eccab commit 8fe3978146d5b694693bfabd4d72ba02f44eccab Author: Mark Johnston AuthorDate: 2026-04-15 13:33:04 +0000 Commit: Mark Johnston CommitDate: 2026-04-22 12:37:34 +0000 linuxkpi: Fix an off-by-one error in the kfifo implementation "total" is the number of slots in the array, so wraparound needs to be done when "first" or "last" is greater than or equal to the number of slots. Note that no consumers of the code are currently connected to the kernel build. Reported by: Stanislav Fort Reviewed by: bz, emaste MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D56371 (cherry picked from commit 52d2fc702b85d56b35f8828fe7efca3cde0d25b7) --- sys/compat/linuxkpi/common/include/linux/kfifo.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/compat/linuxkpi/common/include/linux/kfifo.h b/sys/compat/linuxkpi/common/include/linux/kfifo.h index d2f570781661..b9f6ecacd3d1 100644 --- a/sys/compat/linuxkpi/common/include/linux/kfifo.h +++ b/sys/compat/linuxkpi/common/include/linux/kfifo.h @@ -71,7 +71,7 @@ (_kf)->head[(_kf)->last] = (_e); \ (_kf)->count++; \ (_kf)->last++; \ - if ((_kf)->last > (_kf)->total) \ + if ((_kf)->last >= (_kf)->total) \ (_kf)->last = 0; \ _rc = true; \ } \ @@ -89,7 +89,7 @@ *(_e) = (_kf)->head[(_kf)->first]; \ (_kf)->count--; \ (_kf)->first++; \ - if ((_kf)->first > (_kf)->total) \ + if ((_kf)->first >= (_kf)->total) \ (_kf)->first = 0; \ _rc = true; \ } \