From owner-svn-src-all@freebsd.org Wed Feb 20 17:19:29 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8A0E914F9C91; Wed, 20 Feb 2019 17:19:29 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D08B189C45; Wed, 20 Feb 2019 17:19:25 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x1KHJN2B016176; Wed, 20 Feb 2019 09:19:23 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id x1KHJNwL016175; Wed, 20 Feb 2019 09:19:23 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201902201719.x1KHJNwL016175@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r344364 - vendor/illumos/dist/lib/libdtrace/common In-Reply-To: <201902201705.x1KH5E9V039924@repo.freebsd.org> To: Mark Johnston Date: Wed, 20 Feb 2019 09:19:23 -0800 (PST) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-vendor@freebsd.org, patrick.mooney@joyent.com Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: D08B189C45 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.96)[-0.959,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2019 17:19:29 -0000 > Author: markj > Date: Wed Feb 20 17:05:13 2019 > New Revision: 344364 > URL: https://svnweb.freebsd.org/changeset/base/344364 > > Log: > 9058 postmortem DTrace frequently broken under vmware > > illumos/illumos-gate@793bd7e3617ae7d3d24e8c6b7d6befe35f07ec1f > > Reviewed by: Tim Kordas > Reviewed by: Patrick Mooney > Reviewed by: Yuri Pankov > Reviewed by: Matthew Ahrens > Approved by: Matthew Ahrens > Author: Sam Gwydir > > Modified: > vendor/illumos/dist/lib/libdtrace/common/dt_consume.c > > Modified: vendor/illumos/dist/lib/libdtrace/common/dt_consume.c > ============================================================================== > --- vendor/illumos/dist/lib/libdtrace/common/dt_consume.c Wed Feb 20 14:12:25 2019 (r344363) > +++ vendor/illumos/dist/lib/libdtrace/common/dt_consume.c Wed Feb 20 17:05:13 2019 (r344364) > @@ -24,7 +24,7 @@ > */ > > /* > - * Copyright (c) 2013, Joyent, Inc. All rights reserved. > + * Copyright (c) 2017, Joyent, Inc. All rights reserved. This change to this copyright is very questionable. One should always retain the first date of publication in a copyright statement. I do understand your just importing a change from illumous, but I want it on public record that I have raised issue with this change to a copyright, and this has nothing to do with you personally, or you wanting to bring this code over. > * Copyright (c) 2012 by Delphix. All rights reserved. > */ > > @@ -3010,9 +3010,6 @@ dtrace_consume(dtrace_hdl_t *dtp, FILE *fp, > break; > > timestamp = dt_buf_oldest(buf, dtp); > - assert(timestamp >= dtp->dt_last_timestamp); > - dtp->dt_last_timestamp = timestamp; > - > if (timestamp == buf->dtbd_timestamp) { > /* > * We've reached the end of the time covered > @@ -3026,6 +3023,8 @@ dtrace_consume(dtrace_hdl_t *dtp, FILE *fp, > break; > continue; > } > + assert(timestamp >= dtp->dt_last_timestamp); > + dtp->dt_last_timestamp = timestamp; > > if ((rval = dt_consume_cpu(dtp, fp, > buf->dtbd_cpu, buf, B_TRUE, pf, rf, arg)) != 0) > > -- Rod Grimes rgrimes@freebsd.org