From owner-svn-src-head@freebsd.org Thu Feb 20 21:46:40 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3E8FE2474A6; Thu, 20 Feb 2020 21:46:40 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48Np7z0WTFz41CL; Thu, 20 Feb 2020 21:46:38 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 01KLkXUi076043; Thu, 20 Feb 2020 13:46:33 -0800 (PST) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 01KLkXRM076042; Thu, 20 Feb 2020 13:46:33 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <202002202146.01KLkXRM076042@gndrsh.dnsmgr.net> Subject: Re: svn commit: r358153 - head/usr.sbin/services_mkdb In-Reply-To: To: Ed Maste Date: Thu, 20 Feb 2020 13:46:33 -0800 (PST) CC: Pedro Giffuni , Li-Wen Hsu , Xin LI , Yuri Pankov , src-committers , svn-src-all , svn-src-head Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 48Np7z0WTFz41CL X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of freebsd@gndrsh.dnsmgr.net has no SPF policy when checking 69.59.192.140) smtp.mailfrom=freebsd@gndrsh.dnsmgr.net X-Spamd-Result: default: False [1.81 / 15.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[rgrimes@freebsd.org]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[dnsmgr.net]; AUTH_NA(1.00)[]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; NEURAL_SPAM_MEDIUM(0.45)[0.455,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_SPAM_LONG(0.42)[0.424,0]; RCPT_COUNT_SEVEN(0.00)[8]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(0.03)[ip: (0.13), ipnet: 69.59.192.0/19(0.07), asn: 13868(0.03), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Feb 2020 21:46:40 -0000 [ Charset UTF-8 unsupported, converting... ] > On Thu, 20 Feb 2020 at 09:54, Pedro Giffuni wrote: > > > > On 2020-02-20 09:46, Ed Maste wrote: > > > On Thu, 20 Feb 2020 at 04:56, Li-Wen Hsu wrote: > > >> Please note this is not fixed in ci.freebsd.org yet. The reason is it > > >> directly goes to src/release and perform `make packagesystem` to > > >> generate kernel.txz and base.txz. If I read release(7) correctly, > > >> this should be performed under a fresh installed environment. I am > > >> checking how to fix this. > > > Should we revert the change until a build fix can be committed too? > > > > I am OK with reverting the change, and I am rather surprised such a > > simply change could have broken the build. > > Indeed, this has uncovered a broken dependency in our build process > (i.e., that the build host's services_mkdb is being used). > > IMO we should: > > 1. Revert the change for now (pfg will you take care of it?) > 2. MFC the MAX_PROTO increase as soon as possible > 3. Try to fix the use of host's services_mkdb > 4. Recommit after either #3 is done, or FreeBSD 12.2 and 11.4 are released Agree fully with items 1 to 3, as to item 4 I think needs some work: 4. Recommit services to head after #3 is done 5. MFC Fixes #2 and #3 after a short bake in ^head (1 or 2 weeks) 6. MFC of services file to stable/12&11 after #2 and #3 are shipped in 12.2 and 11.4 respectfully. This should ensure no disruptions to anyone on stable/ happens, though I could probably be convinced that once #3 is fixed the risk here is low. -- Rod Grimes rgrimes@freebsd.org