From owner-freebsd-current Wed Jan 27 21:40:22 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id VAA15956 for freebsd-current-outgoing; Wed, 27 Jan 1999 21:40:22 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from ns.mt.sri.com (sri-gw.MT.net [206.127.105.141]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id VAA15940 for ; Wed, 27 Jan 1999 21:40:19 -0800 (PST) (envelope-from nate@mt.sri.com) Received: from mt.sri.com (rocky.mt.sri.com [206.127.76.100]) by ns.mt.sri.com (8.8.8/8.8.8) with SMTP id WAA10707; Wed, 27 Jan 1999 22:40:17 -0700 (MST) (envelope-from nate@rocky.mt.sri.com) Received: by mt.sri.com (SMI-8.6/SMI-SVR4) id WAA26288; Wed, 27 Jan 1999 22:40:16 -0700 Date: Wed, 27 Jan 1999 22:40:16 -0700 Message-Id: <199901280540.WAA26288@mt.sri.com> From: Nate Williams MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit To: Archie Cobbs Cc: wollman@khavrinen.lcs.mit.edu (Garrett Wollman), current@FreeBSD.ORG Subject: Re: btokup() macro in sys/malloc.h In-Reply-To: <199901280229.SAA20207@bubba.whistle.com> References: <199901280222.VAA14212@khavrinen.lcs.mit.edu> <199901280229.SAA20207@bubba.whistle.com> X-Mailer: VM 6.34 under 19.16 "Lille" XEmacs Lucid Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > Anyway, if we're going to -Wall'ify the kernel (as we should) > then we need to update sytle(9) to reflect that. > > In fact, style(9) should say: > > If at all possible, your code should compile without warnings > when the gcc -Wall flag is given. I disagree. As has been shown many times in the past (and I suspect the down-under constituent will show that at least a couple of the 'warnings' fixes will be wrong and hide bogus code), making -Wall a goal causes people to cover up bad code with bad casts and such. '-Wall' is *NOT* a good design goal. Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message