From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Jul 2 19:10:03 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 78E3C1065678 for ; Wed, 2 Jul 2008 19:10:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 4BDB78FC2F for ; Wed, 2 Jul 2008 19:10:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m62JA3r4074570 for ; Wed, 2 Jul 2008 19:10:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m62JA30r074569; Wed, 2 Jul 2008 19:10:03 GMT (envelope-from gnats) Resent-Date: Wed, 2 Jul 2008 19:10:03 GMT Resent-Message-Id: <200807021910.m62JA30r074569@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Tobias Rehbein Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B43191065728 for ; Wed, 2 Jul 2008 19:08:42 +0000 (UTC) (envelope-from tobias.rehbein@web.de) Received: from fmmailgate03.web.de (fmmailgate03.web.de [217.72.192.234]) by mx1.freebsd.org (Postfix) with ESMTP id C24618FC0A for ; Wed, 2 Jul 2008 19:08:37 +0000 (UTC) (envelope-from tobias.rehbein@web.de) Received: from smtp07.web.de (fmsmtp07.dlan.cinetic.de [172.20.5.215]) by fmmailgate03.web.de (Postfix) with ESMTP id 34293E20ACD9 for ; Wed, 2 Jul 2008 21:08:36 +0200 (CEST) Received: from [88.134.177.26] (helo=sushi.pseudo.local) by smtp07.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.109 #226) id 1KE7gw-0001gm-00 for FreeBSD-gnats-submit@freebsd.org; Wed, 02 Jul 2008 21:08:35 +0200 Received: from sushi.pseudo.local (localhost [127.0.0.1]) by sushi.pseudo.local (8.14.2/8.14.2) with ESMTP id m62J69a5011543 for ; Wed, 2 Jul 2008 21:06:09 +0200 (CEST) (envelope-from tobi@sushi.pseudo.local) Received: (from tobi@localhost) by sushi.pseudo.local (8.14.2/8.14.2/Submit) id m62J69vE011542; Wed, 2 Jul 2008 21:06:09 +0200 (CEST) (envelope-from tobi) Message-Id: <200807021906.m62J69vE011542@sushi.pseudo.local> Date: Wed, 2 Jul 2008 21:06:09 +0200 (CEST) From: Tobias Rehbein Sender: tobias.rehbein@web.de To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/125194: [patch] games/tome package-building is broken X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Tobias Rehbein List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jul 2008 19:10:03 -0000 >Number: 125194 >Category: ports >Synopsis: [patch] games/tome package-building is broken >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jul 02 19:10:02 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Tobias Rehbein >Release: FreeBSD 7.0-STABLE i386 >Organization: >Environment: System: FreeBSD sushi.pseudo.local 7.0-STABLE FreeBSD 7.0-STABLE #10: Sun Jun 29 16:01:51 CEST 2008 tobi@sushi.pseudo.local:/usr/obj/usr/src/sys/SUSHI i386 >Description: The package by make package will install fine but it's not possible to start the game. make install runs T.o.M.Es own install script which changes file permissions. This is not done using the binary package. To fix this I have added the corresponding @exec directives to the pkg-plist. While here I added the creation of the plot directory which is not part of the binary package. While here I replaced @dirrm with @dirrmtry directives to make the deinstall less verbose. Problem is T.o.M.E spams the %%DATADIR%% so it won't deinstall cleanly. To make the user aware of this I added a pkg-deinstall script which will emit a corresponding message. Regards Tobias >How-To-Repeat: Install T.o.M.E using binary package and try to start it. >Fix: --- tome.diff begins here --- diff -ruN games/tome.orig/Makefile games/tome/Makefile --- games/tome.orig/Makefile 2008-05-15 22:12:26.000000000 +0200 +++ games/tome/Makefile 2008-07-02 12:13:20.000000000 +0200 @@ -7,6 +7,7 @@ PORTNAME= tome PORTVERSION= 2.3.5 +PORTREVISION= 1 CATEGORIES= games MASTER_SITES= http://t-o-m-e.net/dl/src/ DISTNAME= tome-235-src @@ -14,6 +15,8 @@ MAINTAINER= peter.thoenen@yahoo.com COMMENT= Roguelike dungeon exploration game based on JRR Tolkien's works +SUB_FILES= pkg-deinstall + ALL_TARGET= # empty MAKEFILE= makefile.bsd USE_GMAKE= yes diff -ruN games/tome.orig/files/pkg-deinstall.in games/tome/files/pkg-deinstall.in --- games/tome.orig/files/pkg-deinstall.in 1970-01-01 01:00:00.000000000 +0100 +++ games/tome/files/pkg-deinstall.in 2008-07-02 12:06:15.000000000 +0200 @@ -0,0 +1,12 @@ +#!/bin/sh +# $FreeBSD$ + +if [ "$2" = "POST-DEINSTALL" ]; then + echo "" + echo "If you are removing T.o.M.E permanently you should run" + echo "the following command:" + echo "" + echo " rm -rf %%DATADIR%%" + echo "" +fi + diff -ruN games/tome.orig/pkg-plist games/tome/pkg-plist --- games/tome.orig/pkg-plist 2008-05-15 22:12:26.000000000 +0200 +++ games/tome/pkg-plist 2008-07-02 16:08:56.000000000 +0200 @@ -1,4 +1,6 @@ bin/tome +@exec chown root:games %F +@exec chmod 2755 %F %%DATADIR%%/apex/.cvsignore %%DATADIR%%/apex/delete.me %%DATADIR%%/apex/scores.raw @@ -446,27 +448,30 @@ %%DATADIR%%/xtra/music/delete.me %%DATADIR%%/xtra/sound/Sound.cfg %%DATADIR%%/xtra/sound/readme.txt -@dirrm %%DATADIR%%/xtra/sound -@dirrm %%DATADIR%%/xtra/music -@dirrm %%DATADIR%%/xtra/graf -@dirrm %%DATADIR%%/xtra/font -@dirrm %%DATADIR%%/xtra -@dirrm %%DATADIR%%/user -@dirrm %%DATADIR%%/scpt -@dirrm %%DATADIR%%/save -@dirrm %%DATADIR%%/pref -@dirrm %%DATADIR%%/plot -@dirrm %%DATADIR%%/patch -@dirrm %%DATADIR%%/note -@dirrm %%DATADIR%%/mods -@dirrm %%DATADIR%%/info -@dirrm %%DATADIR%%/help -@dirrm %%DATADIR%%/file -@dirrm %%DATADIR%%/edit -@dirrm %%DATADIR%%/dngn -@dirrm %%DATADIR%%/data -@dirrm %%DATADIR%%/core -@dirrm %%DATADIR%%/cmov -@dirrm %%DATADIR%%/bone -@dirrm %%DATADIR%%/apex -@dirrm %%DATADIR%% +@exec mkdir %D/%%DATADIR%%/plot +@exec chown -R root:games %D/%%DATADIR%% +@exec chmod -R g+w %D/%%DATADIR%% +@dirrmtry %%DATADIR%%/xtra/sound +@dirrmtry %%DATADIR%%/xtra/music +@dirrmtry %%DATADIR%%/xtra/graf +@dirrmtry %%DATADIR%%/xtra/font +@dirrmtry %%DATADIR%%/xtra +@dirrmtry %%DATADIR%%/user +@dirrmtry %%DATADIR%%/scpt +@dirrmtry %%DATADIR%%/save +@dirrmtry %%DATADIR%%/pref +@dirrmtry %%DATADIR%%/plot +@dirrmtry %%DATADIR%%/patch +@dirrmtry %%DATADIR%%/note +@dirrmtry %%DATADIR%%/mods +@dirrmtry %%DATADIR%%/info +@dirrmtry %%DATADIR%%/help +@dirrmtry %%DATADIR%%/file +@dirrmtry %%DATADIR%%/edit +@dirrmtry %%DATADIR%%/dngn +@dirrmtry %%DATADIR%%/data +@dirrmtry %%DATADIR%%/core +@dirrmtry %%DATADIR%%/cmov +@dirrmtry %%DATADIR%%/bone +@dirrmtry %%DATADIR%%/apex +@dirrmtry %%DATADIR%% --- tome.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: