From owner-freebsd-virtualization@freebsd.org  Tue Jul 12 23:38:52 2016
Return-Path: <owner-freebsd-virtualization@freebsd.org>
Delivered-To: freebsd-virtualization@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 65B0CB97464
 for <freebsd-virtualization@mailman.ysv.freebsd.org>;
 Tue, 12 Jul 2016 23:38:52 +0000 (UTC)
 (envelope-from grehan@freebsd.org)
Received: from alto.onthenet.com.au (alto.OntheNet.com.au [203.13.68.12])
 by mx1.freebsd.org (Postfix) with ESMTP id 1BD7F14BD
 for <freebsd-virtualization@FreeBSD.org>; Tue, 12 Jul 2016 23:38:51 +0000 (UTC)
 (envelope-from grehan@freebsd.org)
Received: from iredmail.onthenet.com.au (iredmail.onthenet.com.au
 [203.13.68.150])
 by alto.onthenet.com.au (Postfix) with ESMTPS id CBD1420A40DA
 for <freebsd-virtualization@FreeBSD.org>;
 Wed, 13 Jul 2016 09:38:43 +1000 (AEST)
Received: from localhost (iredmail.onthenet.com.au [127.0.0.1])
 by iredmail.onthenet.com.au (Postfix) with ESMTP id C60B0280F61
 for <freebsd-virtualization@FreeBSD.org>;
 Wed, 13 Jul 2016 09:38:43 +1000 (AEST)
X-Amavis-Modified: Mail body modified (using disclaimer) -
 iredmail.onthenet.com.au
Received: from iredmail.onthenet.com.au ([127.0.0.1])
 by localhost (iredmail.onthenet.com.au [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id Eei5crAuAJYa for <freebsd-virtualization@FreeBSD.org>;
 Wed, 13 Jul 2016 09:38:43 +1000 (AEST)
Received: from Peters-MacBook-Pro-2.local (unknown [96.82.80.65])
 by iredmail.onthenet.com.au (Postfix) with ESMTPSA id 54F192809F2;
 Wed, 13 Jul 2016 09:38:41 +1000 (AEST)
Subject: Re: bhyve: disable msi and msix on virtio reset?
To: Tycho Nightingale <tycho.nightingale@pluribusnetworks.com>,
 Andriy Gapon <avg@FreeBSD.org>
References: <011771a3-8424-7810-d9db-870ddcea2448@FreeBSD.org>
 <7D5D0A30-1ABA-49F6-83CC-6F398FC25B05@pluribusnetworks.com>
Cc: "freebsd-virtualization@freebsd.org" <freebsd-virtualization@FreeBSD.org>
From: Peter Grehan <grehan@freebsd.org>
Message-ID: <22aa6570-6a2e-e5d6-1882-86b9ffcb15e7@freebsd.org>
Date: Tue, 12 Jul 2016 16:38:45 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:45.0)
 Gecko/20100101 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <7D5D0A30-1ABA-49F6-83CC-6F398FC25B05@pluribusnetworks.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: quoted-printable
X-CMAE-Score: 0
X-CMAE-Analysis: v=2.2 cv=T//OdLCQ c=1 sm=1 tr=0
 a=A6CF0fG5TOl4vs6YHvqXgw==:117 a=mwgbnDbW7alINpy3vhoKyg==:17
 a=N659UExz7-8A:10 a=cAmyUtKerLwA:10 a=pZ2RuUnEugDbEFitAvsA:9
X-BeenThere: freebsd-virtualization@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Discussion of various virtualization techniques FreeBSD supports."
 <freebsd-virtualization.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-virtualization>, 
 <mailto:freebsd-virtualization-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-virtualization/>
List-Post: <mailto:freebsd-virtualization@freebsd.org>
List-Help: <mailto:freebsd-virtualization-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-virtualization>, 
 <mailto:freebsd-virtualization-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jul 2016 23:38:52 -0000

Hi Tycho,

> Yes, writing 0 to the status resister should reset the device
> including all PCIE state.  This implies that vi_reset_dev() needs to
> take the proper actions to bring the associated pci_devinst (which
> from the guest=92s perspective isn=92t a discrete element) back to it=92=
s
> reset state too.

  I'm not sure if the reset also hits PCIe state, if you're counting=20
config space as part of that (e.g. BAR contents). As an example, the=20
FreeBSD guest virtio code doesn't do any config space saves/restores=20
around a reset.

later,

Peter.