From owner-dev-commits-src-branches@freebsd.org Fri Feb 5 17:24:58 2021 Return-Path: Delivered-To: dev-commits-src-branches@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3EC3F54D460; Fri, 5 Feb 2021 17:24:58 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DXMk212gfz3pCs; Fri, 5 Feb 2021 17:24:57 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by mail-io1-xd2d.google.com with SMTP id s24so7911173iob.6; Fri, 05 Feb 2021 09:24:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-transfer-encoding; bh=YXUQ8fCAtlUWut/gGqMSZzYn1GOP6xiHeTMGTn7JSx8=; b=C+FxP5Om84F7xm6yM7I6YUL+MBe5suJyNY47nHAu9O2F8M60lIxR2zlOpDCwS2AZwe aK3xyXgTjEFxyBc0FpcNDjxCBRxZeNUR5Ii7b3uy/4pNeONNs9V7tbkUJ9bMb3Tn6NXV LVYARllYlbMfiBz/yRGpCPe3IQdZk/L8Owzl5itgT1xu16Mvpjzq7lu82xCzWDIWda8u jYEFHjW27Uhn8aTmn72/TvTnFdcbH5TsYIWhUsCHIS5WMNYRHAt3HvWGCjBXshCA07ub tcOC34fsibwVbhRRb+M4X/aU3nSi9bfrDFhYlwO31zvxSMn2jtQI0GmM7Gwt8gj/fWSc i+eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version:content-transfer-encoding; bh=YXUQ8fCAtlUWut/gGqMSZzYn1GOP6xiHeTMGTn7JSx8=; b=VfXaN5wgS6/AH1othaH2I8DTTsErQUz3quC/iFPZNQPFBcyQHTiXPsolRh7/4E0f2e /T1UqaQu1hoDP4cAzjwsDRAfeBwtfwexW+uzC0R7ivT5GryghdgAt1bBr9XoRuuMZ2bQ CyjoYwR9qmDhOHDwivvLF2pWRPrYDcPVqrQweEL45sfVdMEld5ErznOh0OUoKBt/1kZV ls6c8a6ey9Ac0nxAXeaBeGSYCypOiliFkhxHMyNB8IGeGv+cJ3XIhN5ay4KVXhOMq51E DTT5f31re1iXnLssDa7cQ5Tam6oJMxQBVyAEkLGAfbS8vEky4/gnwFCwFCRV4appDP01 eYEA== X-Gm-Message-State: AOAM530IPZcbTxX6DSVbd/e3p+UoK4GKjfCM+1be41Yy8e4fJiYcT4Xq csSRX4Clh85zjrMA+S/CYS0GPi+MCDVc6w== X-Google-Smtp-Source: ABdhPJxXPJNCRNRrxNEKxavKyKsiPgoH3pQNgfRN0PCh69lXwmdTuK2Zw0LqihXkMJwn86lkJkjN4A== X-Received: by 2002:a5d:9413:: with SMTP id v19mr4788516ion.46.1612545896798; Fri, 05 Feb 2021 09:24:56 -0800 (PST) Received: from [127.0.0.1] (173-18-9-215.client.mchsi.com. [173.18.9.215]) by smtp.gmail.com with ESMTPSA id k3sm4758273ioq.22.2021.02.05.09.24.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Feb 2021 09:24:56 -0800 (PST) Date: Fri, 5 Feb 2021 17:24:55 +0000 (UTC) From: Justin Hibbits To: Andriy Gapon Cc: Alfredo Dal'Ava Junior , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Message-ID: In-Reply-To: <2c848b11-ea07-8107-bf7a-5fa617fe3265@FreeBSD.org> References: <202102051652.115GqYVS049749@gitrepo.freebsd.org> <9f35a234-4c6f-7c86-523f-824dc52656aa@FreeBSD.org> <5066e1e2-e4ce-48c3-8015-74810e7b727c@gmail.com> <2c848b11-ea07-8107-bf7a-5fa617fe3265@FreeBSD.org> Subject: Re: git: 6bf9668d9d02 - stable/13 - mrsas: unbreak i386 build MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Correlation-ID: X-Rspamd-Queue-Id: 4DXMk212gfz3pCs X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-branches@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the stable branches of the FreeBSD src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Feb 2021 17:24:58 -0000 Feb 5, 2021 11:14:34 Andriy Gapon : > On 05/02/2021 19:12, Justin Hibbits wrote: >> Feb 5, 2021 10:56:13 Andriy Gapon : >> >>> On 05/02/2021 18:52, Alfredo Dal'Ava Junior wrote: >>>> The branch stable/13 has been updated by alfredo: >>>> >>>> URL: https://cgit.FreeBSD.org/src/commit/?id=3D6bf9668d9d02bdf3e0dafc4= ba1010ef6a9b12247 >>>> >>>> commit 6bf9668d9d02bdf3e0dafc4ba1010ef6a9b12247 >>>> Author:=C2=A0=C2=A0=C2=A0=C2=A0 Alfredo Dal'Ava Junior >>>> AuthorDate: 2021-02-05 18:43:48 +0000 >>>> Commit:=C2=A0=C2=A0=C2=A0=C2=A0 Alfredo Dal'Ava Junior >>>> CommitDate: 2021-02-05 19:50:21 +0000 >>>> >>>> =C2=A0=C2=A0=C2=A0 mrsas: unbreak i386 build >>>> =C2=A0=C2=A0=C2=A0 >>>> =C2=A0=C2=A0=C2=A0 Fix build regression introduced by >>>> =C2=A0=C2=A0=C2=A0 e34a057ca6ebdf8e30ec8b0dc21d18eb450bf36a >>>> =C2=A0=C2=A0=C2=A0 >>>> =C2=A0=C2=A0=C2=A0 Reviewed by:=C2=A0=C2=A0=C2=A0 jhibbits >>> Was it?=C2=A0 I do not see an approval in the review request. >> Yes,=C2=A0 it was reviewed by me,=C2=A0 since he took exactly what I sug= gested, and we discussed over IRC. >> > > My apologies then. > I was confused by the fact that you commented in phabricator but accepted= over > IRC (which I didn't know). > > -- > Andriy Gapon Fully understandable,=C2=A0 especially given the timing of the review to co= mmit,=C2=A0 and in relation to the release process going on. - Justin