From owner-svn-src-head@freebsd.org Sat Aug 8 01:30:48 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7140B379957; Sat, 8 Aug 2020 01:30:48 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BNl6b2dsFz48l6; Sat, 8 Aug 2020 01:30:47 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-ot1-f52.google.com with SMTP id x24so3061601otp.3; Fri, 07 Aug 2020 18:30:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FGAsNu8Kl2Ys8GTtOrfdARhEV2oL0WnSxytVRDmF7Zs=; b=nj+nmyZ3SkbLi9fqAcPlcuRVPFq+vHdt5npBUAK2odzGy5wG1BZD4mMkeCyQAq8kHL DuXfzVamT2/0thROHfEyN4s+o2ynJGCgl1G+wULGEAuF9SoCyyvWb0ILB66tDNyZxFlN IQdMjFgwMSBNwE3ZQAChPCAQDVXH4ReyxymEHXEABUfWDU2XNxvh8Fymlz6mYpJ1HhdG w1sSyCaCsw8KFCyk3JR4sINvVVY2YP7cS9R2CI39z+VPtHZqGX6zoEFKBbW7pSGwmFKg Z2lygwUXot3y+HChhNFKFFd3uQ0YwOafme9Z1tFbbZzg/LhoEYZEB9EXD0n7uk67mz3u bisA== X-Gm-Message-State: AOAM530RQgQ4Bejxe/KGnDPvuiVXRWkw7WQ2DZADDArSQbolV0niRBv6 6BC8/+4ulU7Zlf7eqJ7FvxxMPuuH4rZTnk710PQ4WHRa X-Google-Smtp-Source: ABdhPJwyQ6pRQHSABijfprpPDC/Rw8xD7P2CJJRh+xoFuyqQ0MR56qryuWJIxeMec9ME0KiWZX1t3TMXekt+H2kg7U0= X-Received: by 2002:a05:6830:1612:: with SMTP id g18mr13246762otr.251.1596850245838; Fri, 07 Aug 2020 18:30:45 -0700 (PDT) MIME-Version: 1.0 References: <202008072306.077N6fjP084661@repo.freebsd.org> In-Reply-To: <202008072306.077N6fjP084661@repo.freebsd.org> From: Alan Somers Date: Fri, 7 Aug 2020 19:30:34 -0600 Message-ID: Subject: Re: svn commit: r364044 - in head: share/man/man9 sys/compat/linuxkpi/common/src sys/kern sys/security/audit sys/sys To: Mateusz Guzik Cc: src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 4BNl6b2dsFz48l6 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Aug 2020 01:30:48 -0000 On Fri, Aug 7, 2020 at 5:06 PM Mateusz Guzik wrote: > Author: mjg > Date: Fri Aug 7 23:06:40 2020 > New Revision: 364044 > URL: https://svnweb.freebsd.org/changeset/base/364044 > > Log: > vfs: add VOP_STAT > > The current scheme of calling VOP_GETATTR adds avoidable overhead. > > An example with tmpfs doing fstat (ops/s): > before: 7488958 > after: 7913833 > > Reviewed by: kib (previous version) > Differential Revision: https://reviews.freebsd.org/D25910 > > Modified: > head/share/man/man9/Makefile > head/share/man/man9/VOP_ATTRIB.9 > head/sys/compat/linuxkpi/common/src/linux_compat.c > head/sys/kern/vfs_default.c > head/sys/kern/vfs_syscalls.c > head/sys/kern/vfs_vnops.c > head/sys/kern/vnode_if.src > head/sys/security/audit/audit_arg.c > head/sys/sys/vnode.h > What avoidable overhead? The tmpfs_stat handler that you added in your next commit looks pretty much the same as vop_getattr. I'm missing where the performance improvement comes from. Could you please fill me in? -Alan