From owner-svn-src-all@FreeBSD.ORG Mon Aug 15 08:01:31 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B81F9106564A; Mon, 15 Aug 2011 08:01:31 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 955008FC13; Mon, 15 Aug 2011 08:01:31 +0000 (UTC) Received: from fledge.watson.org (fledge.watson.org [65.122.17.41]) by cyrus.watson.org (Postfix) with ESMTPS id 1419346B32; Mon, 15 Aug 2011 04:01:31 -0400 (EDT) Date: Mon, 15 Aug 2011 09:01:30 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Niclas Zeising In-Reply-To: <4E47EF64.2070405@gmail.com> Message-ID: References: <201108131603.p7DG3e80023093@svn.freebsd.org> <4E47EF64.2070405@gmail.com> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r224842 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2011 08:01:31 -0000 On Sun, 14 Aug 2011, Niclas Zeising wrote: >> When falloc() was broken into separate falloc_noinstall() and finstall(), >> a bug was introduced in kern_openat() such that the error from the vnode >> open operation was overwritten before it was passed as an argument to >> dupfdopen(). This broke operations on /dev/{stdin,stdout,stderr}. Fix >> by preserving the original error number across finstall() so that it is >> still available. > > It might be worth mentioning this in UPDATING or similar, since a kernel > built with clang (I haven't tried gcc) during this window will make it > impossible to do a buildworld without first rebuilding the kernel with this > fix. It also seems to break at least portsnap, and possibly other tools as > well. Entry now in UPDATING, thanks! I've also sent out a warning to current@. Robert