From owner-cvs-all Sat Dec 2 17: 0:54 2000 Delivered-To: cvs-all@freebsd.org Received: from pike.osd.bsdi.com (pike.osd.bsdi.com [204.216.28.222]) by hub.freebsd.org (Postfix) with ESMTP id 85AD137B400; Sat, 2 Dec 2000 17:00:51 -0800 (PST) Received: from laptop.baldwin.cx (john@dhcp246.osd.bsdi.com [204.216.28.246]) by pike.osd.bsdi.com (8.11.1/8.9.3) with ESMTP id eB310XC45908; Sat, 2 Dec 2000 17:00:33 -0800 (PST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200012020040.eB20ew884237@freefall.freebsd.org> Date: Sat, 02 Dec 2000 17:01:05 -0800 (PST) From: John Baldwin To: Bosko Milekic Subject: RE: cvs commit: src/sys/kern uipc_syscalls.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 02-Dec-2000 Bosko Milekic wrote: > bmilekic 2000/12/01 16:40:57 PST > > Modified files: > sys/kern uipc_syscalls.c > Log: > Make sure to free the sf_buf if we've allocated it but fail to allocate > an mbuf (ENOBUFS) before returning so that we don't leak sf_bufs in > the case where we're out of mbufs. > > Submitted by: David Greenman (dg) Should the second argument be NULL rather than PAGE_SIZE to sf_buf_free()? ../../kern/uipc_syscalls.c: In function `sendfile': ../../kern/uipc_syscalls.c:1708: warning: passing arg 2 of `sf_buf_free' makes pointer from integer without a cast From my reading, the args parameter isn't even used by sf_buf_free()... -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message