From owner-freebsd-current@FreeBSD.ORG Mon Jun 2 23:26:11 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 250E6C95; Mon, 2 Jun 2014 23:26:11 +0000 (UTC) Received: from mail-pb0-x233.google.com (mail-pb0-x233.google.com [IPv6:2607:f8b0:400e:c01::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E8A9E2046; Mon, 2 Jun 2014 23:26:10 +0000 (UTC) Received: by mail-pb0-f51.google.com with SMTP id ma3so4730146pbc.10 for ; Mon, 02 Jun 2014 16:26:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:mime-version:in-reply-to:content-type :content-transfer-encoding:message-id:cc:from:subject:date:to; bh=qISLVWTw4ssWSDZWY4aFbGFmvkfCUZbqSB9/AOdI1qo=; b=C6iItDsefvICzoHYY4i7F7YVM0vJBerAOlx0Pv1cLgTB7BwPrDdBvVInoSRfQzwOSu ADHmnTmfQ/ypPtV81w6uSj/W7LpB3+NI/YoNWZ9+3B649el7fH8VvnhMeHquNzvphrEm Uj9luEiLlWmcVaAShYPlEHelpVKPWgOLExS2m8P6/f4nORYaSIUI1jrNpv96hHUYTIfx f0UhkcwdfItJ0kH8chrSM4GiN1dh3ItMuPfNOUrBuEFCgU2AyguovjZGxsSj/8aa2ulw uGoEFi9bfekW8Te4fzJevy54la8xy+xmhnDIdq18SXYIQ4+gAQCkOHlEq8vfvd3AtL8O UkVA== X-Received: by 10.68.213.74 with SMTP id nq10mr44658685pbc.4.1401751570569; Mon, 02 Jun 2014 16:26:10 -0700 (PDT) Received: from [10.187.192.151] ([14.31.6.31]) by mx.google.com with ESMTPSA id io8sm22260752pbc.96.2014.06.02.16.24.15 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 02 Jun 2014 16:26:09 -0700 (PDT) References: Mime-Version: 1.0 (1.0) In-Reply-To: Content-Type: text/plain; charset=gb2312 Content-Transfer-Encoding: quoted-printable Message-Id: <844FB0BB-1AE5-4CFC-8EC9-634E7B0E6125@gmail.com> X-Mailer: iPhone Mail (11B554a) From: =?GB2312?Q?"=BB=C6=CE=C4=BB=D4=40Gmail"?= Subject: Re: [patch] Switch to text mode during efi boot Date: Tue, 3 Jun 2014 07:24:04 +0800 To: Ed Maste Cc: FreeBSD Current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jun 2014 23:26:11 -0000 Ed, Is there any progress about framebuffer corruption? Thanks, Huang Wenhui > =D4=DA 2014=C4=EA5=D4=C222=C8=D5=A3=AC23:54=A3=ACEd Maste =D0=B4=B5=C0=A3=BA >=20 >> On 22 May 2014 11:32, Rafael Esp=A8=AAndola w= rote: >> The attached patch causes both boot1 and loader.efi to switch to text >> mode. This only >> seems to make a difference on Macs where otherwise no information was bei= ng >> displayed. >>=20 >> The ConsoleControl.h file is copied from >> EdkCompatibilityPkg/Foundation/Protocol/ConsoleControl in >> https://github.com/tianocore/edk2. >>=20 >> I tested that both programs are able to change to text mode by >> enabling only one of them at a time. >>=20 >> With this patch I am able to see loaders output on all the macs I >> tried. The kernel boots correctly on a MacPro, but unfortunately it >> doesn't seem to be able to find the efi buffer in a MacBookPro. >=20 > Great, thank you Rafael. There's framebuffer corruption issues on > some other hardware as well, so it may be that the eventual fix for > those will also solve the MBP issue. >=20 >> Some design questions: >>=20 >> * Why do we have both boot1 and loader? It is just the issue with >> building a usb image without root that requires having a boot1 that >> has a predictable size? >=20 > No, boot1.efi only exists so that the loader and related Forth and > config files can be placed in a UFS root filesystem, as is done with > the x86 BIOS boot and on other platforms. This way the UEFI boot > easily integrates with the existing installer and tools. >=20 > We could put the loader and files in the FAT EFI system partition > instead, but it would require more substantial changes in the > installer and system configuration. >=20 >> * Even if we want to keep both boot1 and loader, could boot1 use libefi? >=20 > I don't think there's any fundamental reason we couldn't. However, > we're going to need to take a broader look at reworking some of this > in the context of secure boot anyway (as we look at a signed shim > loader). >=20 >> * Is it ok to always switch to text mode in libefi or should it >> provide a switch_to_text_mode function? >=20 > I suspect it's fine / correct to always switch; we've just been > "lucky" that the current approach works with most firmwares. > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"=