From owner-svn-src-all@FreeBSD.ORG  Thu Aug  8 17:42:00 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 24357FBE;
 Thu,  8 Aug 2013 17:42:00 +0000 (UTC) (envelope-from gjb@FreeBSD.org)
Received: from mail0.glenbarber.us (mail0.glenbarber.us
 [IPv6:2607:fc50:1:2300:1001:1001:1001:face])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id ECE0A2782;
 Thu,  8 Aug 2013 17:41:59 +0000 (UTC)
Received: from glenbarber.us (unknown [IPv6:2001:470:8:120e:1:1:c57c:729])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate) (Authenticated sender: gjb)
 by mail0.glenbarber.us (Postfix) with ESMTPSA id 8FA30AB63;
 Thu,  8 Aug 2013 17:41:58 +0000 (UTC)
DKIM-Filter: OpenDKIM Filter v2.8.3 mail0.glenbarber.us 8FA30AB63
Authentication-Results: mail0.glenbarber.us; dkim=none
 reason="no signature"; dkim-adsp=none
Date: Thu, 8 Aug 2013 13:41:56 -0400
From: Glen Barber <gjb@FreeBSD.org>
To: Hiroki Sato <hrs@FreeBSD.org>
Subject: Re: svn commit: r254094 - head/sys/conf
Message-ID: <20130808174156.GC2162@glenbarber.us>
References: <201308081559.r78Fx1h6034578@svn.freebsd.org>
 <20130809.020153.1826008782812656990.hrs@allbsd.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="CblX+4bnyfN0pR09"
Content-Disposition: inline
In-Reply-To: <20130809.020153.1826008782812656990.hrs@allbsd.org>
X-Operating-System: FreeBSD 10.0-CURRENT amd64
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Aug 2013 17:42:00 -0000


--CblX+4bnyfN0pR09
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 09, 2013 at 02:01:53AM +0900, Hiroki Sato wrote:
>  I think this logic is unnecessarily complex.  svnversion does not
>  need to run twice, at least.
>=20

svnversion is only invoked the first time on the newvers.sh file, so the
impact is minimal.

>  How about the attached patch?
>=20

I have no objection.

Glen


--CblX+4bnyfN0pR09
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (FreeBSD)

iQEcBAEBCAAGBQJSA9hkAAoJEFJPDDeguUajrI4IAJCQD+sRebD2wWbP43iTX0r6
uzsZPIJW+JRIi5nI1CPe+7AtJb+BE9EiObaKlttEb5KpwvdrlDhDoT3Cm/Fug+SY
rpbsdGaUarGSYEry4LJXADZP5EOMgmZclz2J901qnxU93tmtERTzjJcv4PG/xfBc
o3z3C5aJ9p/8YD4tNVCUdYyaCqLMY8q6z0JU76LjhUO/XqEVZgIfJ2sBRcCeiIsl
GDMd5msaTyzq2g+qFapZUPwfkWps/n/vx1pXiqwIrZQp2cceDG5jkmwCaSUpmg25
gwwzRLERo2o1KpLjYh3qeyQsUkFFvgOXVw0CgV8AKq32HqiRkLef7MBXocFHlkU=
=B0Zz
-----END PGP SIGNATURE-----

--CblX+4bnyfN0pR09--