From owner-freebsd-bugs  Mon Apr 21 11:10:04 1997
Return-Path: <owner-bugs>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id LAA03958
          for bugs-outgoing; Mon, 21 Apr 1997 11:10:04 -0700 (PDT)
Received: (from gnats@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id LAA03942;
          Mon, 21 Apr 1997 11:10:01 -0700 (PDT)
Resent-Date: Mon, 21 Apr 1997 11:10:01 -0700 (PDT)
Resent-Message-Id: <199704211810.LAA03942@freefall.freebsd.org>
Resent-From: gnats (GNATS Management)
Resent-To: freebsd-bugs
Resent-Reply-To: FreeBSD-gnats@freefall.FreeBSD.org, jc@irbs.com
Received: from irbs.irbs.com (jc@irbs.irbs.com [199.182.75.129])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id LAA03588
          for <FreeBSD-gnats-submit@freebsd.org>; Mon, 21 Apr 1997 11:02:08 -0700 (PDT)
Received: (from jc@localhost)
	by irbs.irbs.com (8.8.5/8.8.5) id OAA10624;
	Mon, 21 Apr 1997 14:02:04 -0400 (EDT)
Message-Id: <199704211802.OAA10624@irbs.irbs.com>
Date: Mon, 21 Apr 1997 14:02:04 -0400 (EDT)
From: John Capo <jc@irbs.com>
Reply-To: jc@irbs.com
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: kern/3367: 2.1.7.1 panic with route mask == 0
Sender: owner-bugs@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk


>Number:         3367
>Category:       kern
>Synopsis:       2.1.7.1 panic with route mask == 0
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 21 11:10:00 PDT 1997
>Last-Modified:
>Originator:     John Capo
>Organization:
IRBS Engineering
>Release:        FreeBSD 2.1.7.1-RELEASE i386
>Environment:

2.[01] kernel

>Description:

I managed to get a bogus route added via /etc/ppp/ppp.conf that
caused a panic due to the mask associated with the route being 0.

>How-To-Repeat:

It's been a while and I didn't make notes at the time.

>Fix:

Same fix is in 2.2.

Index: route.c
===================================================================
RCS file: /usr/cvs/src/sys/net/route.c,v
retrieving revision 1.23.4.3
diff -u -r1.23.4.3 route.c
--- route.c	1996/06/08 02:02:03	1.23.4.3
+++ route.c	1997/03/16 02:00:25
@@ -511,7 +511,7 @@
 		 * it doesn't fire when we call it there because the node
 		 * hasn't been added to the tree yet.
 		 */
-		if (!(rt->rt_flags & RTF_HOST)) {
+		if (!(rt->rt_flags & RTF_HOST) && rt_mask(rt) != 0) {
 			struct rtfc_arg arg;
 			arg.rnh = rnh;
 			arg.rt0 = rt;
>Audit-Trail:
>Unformatted: