From owner-freebsd-bugs@FreeBSD.ORG  Tue Apr 16 19:00:00 2013
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id EBC5B9F4
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Tue, 16 Apr 2013 19:00:00 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id B97E0FCD
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Tue, 16 Apr 2013 19:00:00 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r3GJ00ER026638
 for <freebsd-bugs@freefall.freebsd.org>; Tue, 16 Apr 2013 19:00:00 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r3GJ00uu026637;
 Tue, 16 Apr 2013 19:00:00 GMT (envelope-from gnats)
Resent-Date: Tue, 16 Apr 2013 19:00:00 GMT
Resent-Message-Id: <201304161900.r3GJ00uu026637@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
 Sven-Thorsten Dietrich <sven@vyatta.com>
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id B87404BA
 for <freebsd-gnats-submit@FreeBSD.org>; Tue, 16 Apr 2013 18:54:36 +0000 (UTC)
 (envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
 by mx1.freebsd.org (Postfix) with ESMTP id AA427F61
 for <freebsd-gnats-submit@FreeBSD.org>; Tue, 16 Apr 2013 18:54:36 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
 by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r3GIsaY2095953
 for <freebsd-gnats-submit@FreeBSD.org>; Tue, 16 Apr 2013 18:54:36 GMT
 (envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
 by red.freebsd.org (8.14.5/8.14.5/Submit) id r3GIsaAO095952;
 Tue, 16 Apr 2013 18:54:36 GMT (envelope-from nobody)
Message-Id: <201304161854.r3GIsaAO095952@red.freebsd.org>
Date: Tue, 16 Apr 2013 18:54:36 GMT
From: Sven-Thorsten Dietrich <sven@vyatta.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Subject: kern/177888: Missing mutex unlock - deadlock multicast subsystem
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Apr 2013 19:00:01 -0000


>Number:         177888
>Category:       kern
>Synopsis:       Missing mutex unlock - deadlock multicast subsystem
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 16 19:00:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Sven-Thorsten Dietrich
>Release:        head / 9.1.0
>Organization:
Vyatta
>Environment:
N/A
>Description:
return inside locked critical section
>How-To-Repeat:
see patch, run set_api_config() appropriately
>Fix:
apply patch

Patch attached with submission follows:

Index: netinet/ip_mroute.c
===================================================================
--- netinet/ip_mroute.c	(revision 249557)
+++ netinet/ip_mroute.c	(working copy)
@@ -825,6 +825,7 @@
     for (i = 0; i < mfchashsize; i++) {
 	if (LIST_FIRST(&V_mfchashtbl[i]) != NULL) {
 	    *apival = 0;
+            MFC_UNLOCK();
 	    return EPERM;
 	}
     }


>Release-Note:
>Audit-Trail:
>Unformatted: